You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "i-love-thinking (via GitHub)" <gi...@apache.org> on 2024/03/10 06:43:19 UTC
[PR] # build(deps): bump antd from 4.19.3 to 5.14.2 in /docs [superset]
i-love-thinking opened a new pull request, #27454:
URL: https://github.com/apache/superset/pull/27454
same as #27330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] # build(deps): bump antd from 4.19.3 to 5.14.2 in /docs [superset]
Posted by "dependabot[bot] (via GitHub)" <gi...@apache.org>.
dependabot[bot] closed pull request #27454: # build(deps): bump antd from 4.19.3 to 5.14.2 in /docs
URL: https://github.com/apache/superset/pull/27454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] # build(deps): bump antd from 4.19.3 to 5.14.2 in /docs [superset]
Posted by "i-love-thinking (via GitHub)" <gi...@apache.org>.
i-love-thinking commented on PR #27454:
URL: https://github.com/apache/superset/pull/27454#issuecomment-1988234136
> Hi... it looks like you deleted some LESS files, but didn't bump the package. It doesn't seem at all the same as the linked PR. Can you tell us more about what you're looking to do here?
Base on [antd V4 to V5](https://ant.design/docs/react/migration-v5)
Because antd V5 has been migrated to css-in-js, and its related less files have been removed. So I just deleted the import statement that shouldn't be there. Then, I manually checked the compilation results, and there was no big problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] # build(deps): bump antd from 4.19.3 to 5.14.2 in /docs [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27454:
URL: https://github.com/apache/superset/pull/27454#issuecomment-1987597666
Hi... it looks like you deleted some LESS files, but didn't bump the package. It doesn't seem at all the same as the linked PR. Can you tell us more about what you're looking to do here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] # build(deps): bump antd from 4.19.3 to 5.14.2 in /docs [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #27454:
URL: https://github.com/apache/superset/pull/27454#issuecomment-1989122669
Ahh, ok, so this is a step we'd do _if we were_ on antd V5. We're not there yet, and will probably close that other PR while we figure out how to go about that upgrade, which will cause a lot of stying/functionality issues to contend with. I wish it were as easy as just bumping the version :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org