You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Craig Pell <as...@erasurewars.net> on 2019/02/18 21:34:43 UTC
How to commit?
I have written a working solution for
<https://bz.apache.org/bugzilla/show_bug.cgi?id=62772> and
<https://bz.apache.org/bugzilla/show_bug.cgi?id=62789>, the requests for
the <jar> task to support modular attributes. My code modifies
module-info.class directly in the .jar file. (It actually wasn’t as
hard as I was expecting it to be.)
I would love to submit the changes, but I’m not clear on how to do it
using gitbox. I can clone the codebase easily enough, but I don’t know
how to get an account there in order to submit changes.
I figured I could just follow the instructions at
<https://gitbox.apache.org/setup/>, but that requires logging into
<https://id.apache.org>, which in turn requires an Apache user ID, which
I don’t seem to have. When I submitted an ICLA a few months ago, I
didn’t specify a desired user ID. I’m now thinking I should have, but
I’m not sure how to rectify the situation.
From what I’ve been reading, it appears it’s still possible to use
GitHub, but I’m not certain. And even if it is possible and
permissible, I’m not sure whether I should do that, or if I should be
using gitbox as much as possible now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: How to commit?
Posted by Jaikiran Pai <ja...@apache.org>.
Hi Craig,
Commits to the repository are only allowed for committers of the
project. For contributing patches (like this one), you can use the
github pull request process. Once reviewed, the merge will then be done
by one of the existing project committers and the contribution will be
credited to you.
-Jaikiran
On 19/02/19 3:04 AM, Craig Pell wrote:
> I have written a working solution for
> <https://bz.apache.org/bugzilla/show_bug.cgi?id=62772> and
> <https://bz.apache.org/bugzilla/show_bug.cgi?id=62789>, the requests
> for the <jar> task to support modular attributes. My code modifies
> module-info.class directly in the .jar file. (It actually wasn’t as
> hard as I was expecting it to be.)
>
> I would love to submit the changes, but I’m not clear on how to do it
> using gitbox. I can clone the codebase easily enough, but I don’t
> know how to get an account there in order to submit changes.
>
> I figured I could just follow the instructions at
> <https://gitbox.apache.org/setup/>, but that requires logging into
> <https://id.apache.org>, which in turn requires an Apache user ID,
> which I don’t seem to have. When I submitted an ICLA a few months
> ago, I didn’t specify a desired user ID. I’m now thinking I should
> have, but I’m not sure how to rectify the situation.
>
> From what I’ve been reading, it appears it’s still possible to use
> GitHub, but I’m not certain. And even if it is possible and
> permissible, I’m not sure whether I should do that, or if I should be
> using gitbox as much as possible now.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org