[jira] [Resolved] (IMPALA-11380) impala-shell's VerticalOutputFormatter may incorrectly strip trailing whitespace

["yx91490 (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

yx91490 resolved IMPALA-11380.
------------------------------
    Fix Version/s: Impala 4.2.0
       Resolution: Fixed

> impala-shell's VerticalOutputFormatter may incorrectly strip trailing whitespace
> --------------------------------------------------------------------------------
>
>                 Key: IMPALA-11380
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11380
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>    Affects Versions: Impala 4.2.0
>            Reporter: Joe McDonnell
>            Assignee: yx91490
>            Priority: Major
>             Fix For: Impala 4.2.0
>
>
> From looking at VerticalOutputFormatter, it looks like it could suffer from the same issue that we saw in IMPALA-11332
>  
> {noformat}
>     for r, row in enumerate(rows):
>       if sys.version_info.major == 2:
>         row = [val.encode('utf-8', 'replace') if isinstance(val, unicode) else val
>             for val in row]
>       writer.writerow(["************************************** " +
>         str(r + 1) + ".row **************************************"])
>       for c, val in enumerate(row):
>         row[c] = self.column_names[c].rjust(self.column_name_max_len) + ": " + val
>       writer.writerow(row)
>     rows = temp_buffer.getvalue().rstrip() <------- here
>     temp_buffer.close()
> {noformat}
> We should verify the problem and fix it. It seems like the rstrip() should follow the solution from IMPALA-11332 and strip only the newline.
> See [https://github.com/apache/impala/commit/c41e6941cafad453819b57e78b2083a3e64496e0]
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)