[GitHub] [doris] ByteYue commented on a diff in pull request #11169: [feature](FE): add new property to control whether use light schema change or not

[GitBox <gi...@apache.org>]

ByteYue commented on code in PR #11169:
URL: https://github.com/apache/doris/pull/11169#discussion_r937396463


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalDataSource.java:
##########
@@ -1731,6 +1726,26 @@ private void createOlapTable(Database db, CreateTableStmt stmt) throws UserExcep
         // this should be done before create partition.
         Map<String, String> properties = stmt.getProperties();
 
+        // get use light schema change
+        Boolean useLightSchemaChange = true;

Review Comment:
   Actually it wouldn't have any effect cause useLightSchemaChange would be assigned value by PropertyAnalyzer.analyzeUseLightSchemaChange which is set to false by default. But it's confusing indeed. Will change it soon.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org