You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/02 18:13:06 UTC

[GitHub] [superset] diegomedina248 commented on a diff in pull request #19540: fix: View Results Doesn't Match Chart After Refreshing Cache

diegomedina248 commented on code in PR #19540:
URL: https://github.com/apache/superset/pull/19540#discussion_r863069949


##########
superset-frontend/src/explore/components/DataTablesPane/index.tsx:
##########
@@ -242,9 +255,13 @@ export const DataTablesPane = ({
         ...prevIsLoading,
         [resultType]: true,
       }));
+
+      chartUpdateCacheInvalidationStatus(false);
+
       return getChartDataRequest({
         formData: queryFormData,
         resultFormat: 'json',
+        force: !!latestQueryCacheInvalidatedRef.current,
         resultType,
         ownState,
       })

Review Comment:
   @zhaoyongjie looks good to me! feel free to close this PR once yours lands here. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org