[GitHub] [bigtop] iwasakims commented on a diff in pull request #1053: BIGTOP-3870: Adjust Phoenix dependency of phoenix-hbase-compat for HBase-2.13 and Hadoop-3.3.4

[GitBox <gi...@apache.org>]

iwasakims commented on code in PR #1053:
URL: https://github.com/apache/bigtop/pull/1053#discussion_r1022657546


##########
bigtop-packages/src/common/phoenix/patch1-phoenix-hbase-compat.diff:
##########
@@ -0,0 +1,69 @@
+diff --git a/phoenix-hbase-compat-2.4.1/pom.xml b/phoenix-hbase-compat-2.4.1/pom.xml
+index de397d869..ead8bcf9c 100644
+--- a/phoenix-hbase-compat-2.4.1/pom.xml
++++ b/phoenix-hbase-compat-2.4.1/pom.xml
+@@ -31,7 +31,7 @@
+   <description>Compatibility module for HBase 2.4.1+</description>
+ 
+   <properties>
+-    <hbase24.compat.version>2.4.1</hbase24.compat.version>
++    <hbase24.compat.version>2.4.13</hbase24.compat.version>
+   </properties>
+ 
+   <dependencies>
+diff --git a/pom.xml b/pom.xml
+index b0a36925e..7a7887170 100644
+--- a/pom.xml
++++ b/pom.xml
+@@ -80,10 +80,11 @@
+     <!-- Hadoop and Hbase-thirdparty version -->
+     <!-- These are expected to be overridden to conform to cluster versions
+     along with hbase.version (defined in profiles) -->
+-    <hadoop.version>3.1.4</hadoop.version>
+-    <hbase.thirdparty.version>2.2.1</hbase.thirdparty.version>
++    <hadoop.version>3.3.4</hadoop.version>

Review Comment:
   We are usually using [do-component-build](https://github.com/apache/bigtop/blob/master/bigtop-packages/src/common/phoenix/do-component-build) to adjust versions if it can be overridden by just properties.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@bigtop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org