You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/14 10:00:34 UTC

[GitHub] [incubator-shardingsphere] tristaZero opened a new pull request #4312: support parsing multiple parameter-marker from one expr

tristaZero opened a new pull request #4312: support parsing multiple parameter-marker from one expr
URL: https://github.com/apache/incubator-shardingsphere/pull/4312
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4312: support parsing multiple parameter-marker from one expr

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4312: support parsing multiple parameter-marker from one expr
URL: https://github.com/apache/incubator-shardingsphere/pull/4312
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #4312: support parsing multiple parameter-marker from one expr

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4312: support parsing multiple parameter-marker from one expr
URL: https://github.com/apache/incubator-shardingsphere/pull/4312#issuecomment-586202432
 
 
   ## Pull Request Test Coverage Report for [Build 1731](https://coveralls.io/builds/28732505)
   
   * **0** of **22**   **(0.0%)**  changed or added relevant lines in **2** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.07%**) to **62.675%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28732505/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L386) | 0 | 11 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28732505/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L366) | 0 | 11 | 0.0%
   <!-- | **Total:** | **0** | **22** | **0.0%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28732505/badge)](https://coveralls.io/builds/28732505) |
   | :-- | --: |
   | Change from base [Build 855](https://coveralls.io/builds/28731373): |  -0.07% |
   | Covered Lines: | 11049 |
   | Relevant Lines: | 17629 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #4312: support parsing multiple parameter-marker from one expr

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4312: support parsing multiple parameter-marker from one expr
URL: https://github.com/apache/incubator-shardingsphere/pull/4312#issuecomment-586202432
 
 
   ## Pull Request Test Coverage Report for [Build 1736](https://coveralls.io/builds/28733160)
   
   * **0** of **22**   **(0.0%)**  changed or added relevant lines in **2** files are covered.
   * **9** unchanged lines in **1** file lost coverage.
   * Overall coverage decreased (**-1.4%**) to **61.308%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLVisitor.java](https://coveralls.io/builds/28733160/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLVisitor.java#L386) | 0 | 11 | 0.0%
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-postgresql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/PostgreSQLVisitor.java](https://coveralls.io/builds/28733160/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FPostgreSQLVisitor.java#L366) | 0 | 11 | 0.0%
   <!-- | **Total:** | **0** | **22** | **0.0%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-oracle/src/main/java/org/apache/shardingsphere/sql/parser/OracleParserEntry.java](https://coveralls.io/builds/28733160/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-oracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2FOracleParserEntry.java#L56) | 9 | 0% |
   <!-- | **Total:** | **9** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28733160/badge)](https://coveralls.io/builds/28733160) |
   | :-- | --: |
   | Change from base [Build 855](https://coveralls.io/builds/28731373): |  -1.4% |
   | Covered Lines: | 11049 |
   | Relevant Lines: | 18022 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #4312: support parsing multiple parameter-marker from one expr

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #4312: support parsing multiple parameter-marker from one expr
URL: https://github.com/apache/incubator-shardingsphere/pull/4312#discussion_r379348103
 
 

 ##########
 File path: sharding-sql-test/src/main/resources/sql/supported/dml/update.xml
 ##########
 @@ -20,7 +20,7 @@
     <sql-case id="update_without_alias" value="UPDATE t_order SET status = ? WHERE order_id = ? AND user_id = ?" />
     <sql-case id="update_with_alias" value="UPDATE t_order AS o SET o.status = ? WHERE o.order_id = ? AND o.user_id = ?" db-types="MySQL,H2" />
     <!-- FIXME cannot parse multiple parameter-marker from one expr -->
 
 Review comment:
   We should remove FIXME if the case fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services