[jira] Commented: (HARMONY-5914) Can't build with gcc >= 4.2: LinuxNativeFont.c:251: warning: cast from pointer to integer of different size

["Senaka Fernando (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HARMONY-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614289#action_12614289 ] 

Senaka Fernando commented on HARMONY-5914:
------------------------------------------

Hi all,

I ran into exactly the same issue. In my system, I have set the -Werror flag by default. However, since April 2008, I was not able to build Harmony with this flag. This is justifiable, as all the warnings may not make sense. And, under valid reasons you may go ahead with a warning. But, when I last built Harmony, yesterday morning, my build failed. At exactly the same point. I then grepped for all occurrences of -Werror and then removed them and rebuilt. Then I managed to successfully build Harmony. I have two questions here.

1. Normally, is it the practice to leave -Werror flags intact in a build system? There might be users who are not much familiar with C compiling who will not understand such a failure.

2. If the -Werror flag was added on purpose, I believe that something is not coded as expected.

Here is a svn diff that would help.

Index: working_vm/make/vm/jitrino.xml
===================================================================
--- working_vm/make/vm/jitrino.xml      (revision 676990)
+++ working_vm/make/vm/jitrino.xml      (working copy)
@@ -184,7 +184,6 @@
             <compiler id="plaf.cpp.compiler" extends="common.cpp.compiler">
                 <compilerarg value="-fmessage-length=0" if="is.gcc"/>
                 <compilerarg value="-Wall" if="is.gcc"/>
-                <compilerarg value="-Werror" if="is.gcc"/>

                 <compilerarg value="-x" />
                 <compilerarg value="c++" />
Index: working_classlib/depends/build/defines.mk
===================================================================
--- working_classlib/depends/build/defines.mk   (revision 676990)
+++ working_classlib/depends/build/defines.mk   (working copy)
@@ -34,7 +34,7 @@
 EXERPATHPREFIX = -Xlinker -z -Xlinker origin -Xlinker -rpath \
        -Xlinker \$$ORIGIN/ -Xlinker -rpath-link \
        -Xlinker
-WARNFLAGS=-Werror
+WARNFLAGS=

 include $(HY_HDK)/build/make/platform/$(HY_PLATFORM).mk

Regards,
Senaka

> Can't build with gcc >= 4.2: LinuxNativeFont.c:251: warning: cast from pointer to integer of different size
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-5914
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5914
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Ubuntu 8.04, drlvm svn head.
>            Reporter: Steve Blackburn
>
> We run nightly regressions of various VMs against the dacapo suite (building from svn nightly).  I was trying to get things working on an upgraded box.  When I tried to build drlvm, I found that it would not compile with gcc-4.2.3.   The work-around is either to use an older gcc, or to turn of -Werror; neither are ideal.  Or should I be doing something different with my build? (I just followed the standard instructions for a federated build).
> The code generating the warnings looks questionable, so probably the right solution (in this first instance) is to fix the code.
> # my gcc
> working_classlib/modules/awt/src/main/native/linuxfont/unix$  gcc -v
> Using built-in specs.
> Target: i486-linux-gnu
> Configured with: ../src/configure -v --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --with-gxx-include-dir=/usr/include/c++/4.2 --program-suffix=-4.2 --enable-clocale=gnu --enable-libstdcxx-debug --enable-objc-gc --enable-mpfr --enable-targets=all --enable-checking=release --build=i486-linux-gnu --host=i486-linux-gnu --target=i486-linux-gnu
> Thread model: posix
> gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7)
> # builds fine with gcc-3.3
> working_classlib/modules/awt/src/main/native/linuxfont/unix$ gcc-3.3 -DLINUX -DLINUX_X86 -DHYX86 -DIPv6_FUNCTION_SUPPORT -D_REENTRANT -I/home/dacapo/regression/vms/scm/drlvm-svn/working_classlib/deploy/include -I/home/dacapo/regression/vms/scm/drlvm-svn/working_classlib/deploy/jdk/include -I. -I../shared/ -Icommon -I/usr/X11R6/include -I/usr/include/freetype2 -Iinclude -I../../fontlib/unix -I../../fontlib/shared  -fpic -march=pentium3 -ggdb -O0  -Werror   -c -o LinuxNativeFont.o LinuxNativeFont.c
> # builds fine with gcc-4.1
> gcc-4.1 -DLINUX -DLINUX_X86 -DHYX86 -DIPv6_FUNCTION_SUPPORT -D_REENTRANT -I/home/dacapo/regression/vms/scm/drlvm-svn/working_classlib/deploy/include -I/home/dacapo/regression/vms/scm/drlvm-svn/working_classlib/deploy/jdk/include -I. -I../shared/ -Icommon -I/usr/X11R6/include -I/usr/include/freetype2 -Iinclude -I../../fontlib/unix -I../../fontlib/shared  -fpic -march=pentium3 -ggdb -O0  -Werror   -c -o LinuxNativeFont.o LinuxNativeFont.c
> # dies with gcc-4.2.3
> gcc-4.2 -DLINUX -DLINUX_X86 -DHYX86 -DIPv6_FUNCTION_SUPPORT -D_REENTRANT -I/home/dacapo/regression/vms/scm/drlvm-svn/working_classlib/deploy/include -I/home/dacapo/regression/vms/scm/drlvm-svn/working_classlib/deploy/jdk/include -I. -I../shared/ -Icommon -I/usr/X11R6/include -I/usr/include/freetype2 -Iinclude -I../../fontlib/unix -I../../fontlib/shared  -fpic -march=pentium3 -ggdb -O0  -Werror   -c -o LinuxNativeFont.o LinuxNativeFont.c
> cc1: warnings being treated as errors
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_initializeFont':
> LinuxNativeFont.c:251: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:257: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:284: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:417: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:429: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:440: warning: cast from pointer to integer of different size
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_initializeFontFromFP':
> LinuxNativeFont.c:487: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:493: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:508: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:520: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:592: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:604: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:615: warning: cast from pointer to integer of different size
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_getFonts':
> LinuxNativeFont.c:969: warning: cast from pointer to integer of different size
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_NativeInitGlyphBitmap':
> LinuxNativeFont.c:1390: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:1399: warning: cast from pointer to integer of different size
> LinuxNativeFont.c:1409: warning: cast from pointer to integer of different size
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_getGlyphOutline':
> LinuxNativeFont.c:1636: warning: cast from pointer to integer of different size
> # dies with gcc 4.3.2
> $ gcc-4.3 -DLINUX -DLINUX_X86 -DHYX86 -DIPv6_FUNCTION_SUPPORT -D_REENTRANT -I/home/dacapo/regression/vms/scm/drlvm-svn/working_classlib/deploy/include -I/home/dacapo/regression/vms/scm/drlvm-svn/working_classlib/deploy/jdk/include -I. -I../shared/ -Icommon -I/usr/X11R6/include -I/usr/include/freetype2 -Iinclude -I../../fontlib/unix -I../../fontlib/shared  -fpic -march=pentium3 -ggdb -O0  -Werror   -c -o LinuxNativeFont.o LinuxNativeFont.c
> cc1: warnings being treated as errors
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_initializeFont':
> LinuxNativeFont.c:251: error: cast from pointer to integer of different size
> LinuxNativeFont.c:257: error: cast from pointer to integer of different size
> LinuxNativeFont.c:284: error: cast from pointer to integer of different size
> LinuxNativeFont.c:417: error: cast from pointer to integer of different size
> LinuxNativeFont.c:429: error: cast from pointer to integer of different size
> LinuxNativeFont.c:440: error: cast from pointer to integer of different size
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_initializeFontFromFP':
> LinuxNativeFont.c:487: error: cast from pointer to integer of different size
> LinuxNativeFont.c:493: error: cast from pointer to integer of different size
> LinuxNativeFont.c:508: error: cast from pointer to integer of different size
> LinuxNativeFont.c:520: error: cast from pointer to integer of different size
> LinuxNativeFont.c:592: error: cast from pointer to integer of different size
> LinuxNativeFont.c:604: error: cast from pointer to integer of different size
> LinuxNativeFont.c:615: error: cast from pointer to integer of different size
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_getFonts':
> LinuxNativeFont.c:969: error: cast from pointer to integer of different size
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_NativeInitGlyphBitmap':
> LinuxNativeFont.c:1390: error: cast from pointer to integer of different size
> LinuxNativeFont.c:1399: error: cast from pointer to integer of different size
> LinuxNativeFont.c:1409: error: cast from pointer to integer of different size
> LinuxNativeFont.c: In function 'Java_org_apache_harmony_awt_gl_font_LinuxNativeFont_getGlyphOutline':
> LinuxNativeFont.c:1636: error: cast from pointer to integer of different size

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.