Re: Review Request 14023: NetworkManager Exception Fix Due to call to getDhcpServiceProvider()

[daan Hoogland <da...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14023/#review33694
-----------------------------------------------------------

Ship it!


6523c068695d0431070060667c222eb40d54b14d

- daan Hoogland


On Sept. 6, 2013, 10:26 p.m., Soheil Eizadi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14023/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 10:26 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> I ran the master branch with my NetworkElement integrated which provides DHCP service. In my use case I was able to create a VM but when I deleted it there was an exception in the NetworkManager when it called:
> 
> isDhcpAccrossMultipleSubnetsSupported() >> getDhcpServiceProvider()
> 
> 
> My DHCP Provider is a NetworkElement but does not implement the DhcpServiceProvider interface.
> 
> 
>    public DhcpServiceProvider getDhcpServiceProvider(Network network) {
> 
>         String DhcpProvider = _ntwkSrvcDao.getProviderForServiceInNetwork(network.getId(), Service.Dhcp);
> 
> 
>         if (DhcpProvider == null) {
> 
>             s_logger.debug("Network " + network + " doesn't support service " + Service.Dhcp.getName());
> 
>             return null;
> 
>         }
> 
> 
>         return (DhcpServiceProvider)_networkModel.getElementImplementingProvider(DhcpProvider);
> 
> 
>     }
> 
> 
> There is a check in the NetworkManager in the Prepare stage but a similar check is missing in Release stage.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkManagerImpl.java ae27554 
> 
> Diff: https://reviews.apache.org/r/14023/diff/
> 
> 
> Testing
> -------
> 
> I verified in my environment where due to VM expunge failing to NetworkManager exception the system would retry on a timer. After the fix the VM was removed from the system after the first retry.
> 
> 
> Thanks,
> 
> Soheil Eizadi
> 
>