[jira] [Commented] (AIRFLOW-5547) S3_hook creates a new connection even if a connection exists for method calls

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054925#comment-17054925 ] 

ASF GitHub Bot commented on AIRFLOW-5547:
-----------------------------------------

swiftomkar commented on pull request #7665: [AIRFLOW-5547] S3_hook creates a new connection even if a connection exists for method calls
URL: https://github.com/apache/airflow/pull/7665
 
 
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> S3_hook creates a new connection even if a connection exists for method calls
> -----------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5547
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5547
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: aws
>    Affects Versions: 1.10.5
>            Reporter: Omkar
>            Assignee: Omkar
>            Priority: Major
>   Original Estimate: 12h
>  Remaining Estimate: 12h
>
> S3_hook creates a new connection everytime a method is called. This can be avoided with a simple fix that checks if a connection exists before a new connection is established. This fix will save a lot of compute cycles where methods are called multiple times in a short span and thus improving performance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)