[GitHub] [trafficserver] masaori335 commented on a change in pull request #7282: Reduce the number of write operation on H2

[GitBox <gi...@apache.org>]

masaori335 commented on a change in pull request #7282:
URL: https://github.com/apache/trafficserver/pull/7282#discussion_r508890586



##########
File path: proxy/http2/Http2ClientSession.cc
##########
@@ -299,18 +299,38 @@ Http2ClientSession::set_half_close_local_flag(bool flag)
 }
 
 int64_t
-Http2ClientSession::xmit(const Http2TxFrame &frame)
+Http2ClientSession::xmit(const Http2TxFrame &frame, bool flush)
 {
   int64_t len = frame.write_to(this->write_buffer);
+  this->_pending_sending_data_size += len;
+
+  // Force flush for some cases
+  if (!flush) {
+    // Flush if we already use half of the buffer to avoid adding a new block to the chain.

Review comment:
       Did you check this behavior? I bit doubt calling `flush()` prevents adding a new block. Because `write_reenable()` doesn't do actual write.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org