You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Ernesto Salgado Suárez (JIRA)" <ji...@apache.org> on 2007/12/16 21:09:33 UTC

[jira] Created: (WW-2378) Decorator patterns don't work in struts2-sitemesh-plugin. Only works the pattern /* or *.

Decorator patterns don't work in struts2-sitemesh-plugin. Only works the pattern /* or *.
-----------------------------------------------------------------------------------------

                 Key: WW-2378
                 URL: https://issues.apache.org/struts/browse/WW-2378
             Project: Struts 2
          Issue Type: Bug
            Reporter: Ernesto Salgado Suárez
            Assignee: Joe Walnes
            Priority: Critical


Joe. In file PageFilter.java (about line 52) after executing this line

            // parse data into Page object (or continue as normal if Page not parseable)
            Page page = parsePage(request, response, chain);

some of the attributes of the request object changes. One of them is _servletPath and its value is set to empty String "". This causes that the method public Decorator getDecorator( HttpServletRequest request, Page page ) in file ConfigDecoratorMapper.java fails finding a pattern. In the first line of this method I see this line:

            String thisPath = request.getServletPath();

So thisPath is the emptyString. 

This causes that only the /* and * patterns works when using struts2 + sitemesh.

Are you agree with me?

Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-2378) Decorator patterns don't work in struts2-sitemesh-plugin. Only works the pattern /* or *.

Posted by "Ernesto Salgado Suárez (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ernesto Salgado Suárez updated WW-2378:
---------------------------------------

    Component/s: Plugin - SiteMesh

> Decorator patterns don't work in struts2-sitemesh-plugin. Only works the pattern /* or *.
> -----------------------------------------------------------------------------------------
>
>                 Key: WW-2378
>                 URL: https://issues.apache.org/struts/browse/WW-2378
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - SiteMesh
>            Reporter: Ernesto Salgado Suárez
>            Assignee: Joe Walnes
>            Priority: Critical
>
> Joe. In file PageFilter.java (about line 52) after executing this line
>             // parse data into Page object (or continue as normal if Page not parseable)
>             Page page = parsePage(request, response, chain);
> some of the attributes of the request object changes. One of them is _servletPath and its value is set to empty String "". This causes that the method public Decorator getDecorator( HttpServletRequest request, Page page ) in file ConfigDecoratorMapper.java fails finding a pattern. In the first line of this method I see this line:
>             String thisPath = request.getServletPath();
> So thisPath is the emptyString. 
> This causes that only the /* and * patterns works when using struts2 + sitemesh.
> Are you agree with me?
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (WW-2378) Decorator patterns don't work in struts2-sitemesh-plugin. Only works the pattern /* or *.

Posted by "Ernesto Salgado Suárez (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ernesto Salgado Suárez updated WW-2378:
---------------------------------------


Oh! I see you have fixed this in 2.3 version of sitemesh:

        else if ("".equals(thisPath)) {
            // in servlet 2.4, if a request is mapped to '/*', getServletPath returns null (SIM-130)
            thisPath = request.getPathInfo();
        }

So I will change my pom dependency from 

		<dependency>
			<groupId>org.apache.struts</groupId>
			<artifactId>struts2-sitemesh-plugin</artifactId>
			<version>2.0.11</version>
		</dependency>

to

		<dependency>
			<groupId>opensymphony</groupId>
			<artifactId>sitemesh</artifactId>
			<version>2.3</version>
		</dependency>

> Decorator patterns don't work in struts2-sitemesh-plugin. Only works the pattern /* or *.
> -----------------------------------------------------------------------------------------
>
>                 Key: WW-2378
>                 URL: https://issues.apache.org/struts/browse/WW-2378
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - SiteMesh
>            Reporter: Ernesto Salgado Suárez
>            Assignee: Joe Walnes
>            Priority: Critical
>
> Joe. In file PageFilter.java (about line 52) after executing this line
>             // parse data into Page object (or continue as normal if Page not parseable)
>             Page page = parsePage(request, response, chain);
> some of the attributes of the request object changes. One of them is _servletPath and its value is set to empty String "". This causes that the method public Decorator getDecorator( HttpServletRequest request, Page page ) in file ConfigDecoratorMapper.java fails finding a pattern. In the first line of this method I see this line:
>             String thisPath = request.getServletPath();
> So thisPath is the emptyString. 
> This causes that only the /* and * patterns works when using struts2 + sitemesh.
> Are you agree with me?
> Thanks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.