You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by rb...@covalent.net on 2000/11/11 00:57:37 UTC
Re: cvs commit: apache-2.0/src/modules/standard config.m4 mod_userdir.c
I much prefer the wrapper that Sascha proposed. At least that attempts to
take care of thread-safety.
Ryan
> -APACHE_CHECK_STANDARD_MODULE(userdir, mapping of user requests, , yes)
> +APACHE_CHECK_STANDARD_MODULE(userdir, mapping of user requests, , yes, [
> + AC_CHECK_FUNCS(getpwnam_r)
> +])
> APACHE_CHECK_STANDARD_MODULE(suexec, set uid and gid for spawned processes, , no)
> APACHE_CHECK_STANDARD_MODULE(alias, translation of requests, , yes)
>
> 1.26 +1 -1 apache-2.0/src/modules/standard/mod_userdir.c
>
> Index: mod_userdir.c
> ===================================================================
> RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_userdir.c,v
> retrieving revision 1.25
> retrieving revision 1.26
> diff -u -r1.25 -r1.26
> --- mod_userdir.c 2000/11/10 18:18:57 1.25
> +++ mod_userdir.c 2000/11/10 23:52:18 1.26
> @@ -326,7 +326,7 @@
> #else /* WIN32 */
> struct passwd *pw;
>
> -#if APR_HAS_THREADS && defined(_POSIX_THREAD_SAFE_FUNCTIONS)
> +#if APR_HAS_THREADS && defined(HAVE_GETPWNAM_R)
> struct passwd pwd;
> size_t buflen = sysconf(_SC_GETPW_R_SIZE_MAX);
> char *buf = apr_pcalloc(r->pool, buflen);
>
>
>
>
>
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apache-2.0/src/modules/standard config.m4 mod_userdir.c
Posted by rb...@covalent.net.
On 10 Nov 2000, Jeff Trawick wrote:
> rbb@covalent.net writes:
>
> > I much prefer the wrapper that Sascha proposed. At least that attempts to
> > take care of thread-safety.
>
> Agreed...
>
> I think we can expect to hit this same issue elsewhere...
>
> Where do you want the wrapper? Where should the declarations be? Is
> APR o.k.?
See my last message on this topic. I have changed my mind. We shouldn't
even be considering this case. We can't make these functions thread-safe
on all platforms, so we should just punt threaded support on those
platforms.
Ryan
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: apache-2.0/src/modules/standard config.m4 mod_userdir.c
Posted by Jeff Trawick <tr...@bellsouth.net>.
rbb@covalent.net writes:
> I much prefer the wrapper that Sascha proposed. At least that attempts to
> take care of thread-safety.
Agreed...
I think we can expect to hit this same issue elsewhere...
Where do you want the wrapper? Where should the declarations be? Is
APR o.k.?
--
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...