[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #873: GUACAMOLE-926: Fix UTF-8 handling in batch import files.

["jmuehlner (via GitHub)" <gi...@apache.org>]

jmuehlner commented on code in PR #873:
URL: https://github.com/apache/guacamole-client/pull/873#discussion_r1199464160


##########
guacamole/src/main/frontend/src/app/import/controllers/importConnectionsController.js:
##########
@@ -693,7 +693,7 @@ angular.module('import').controller('importConnectionsController', ['$scope', '$
         });
 
         // Read all the data into memory
-        $scope.fileReader.readAsBinaryString(file);
+        $scope.fileReader.readAsText(file);

Review Comment:
   This method defaults to a UTF-8 encoding if not otherwise specified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org