You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/19 02:02:54 UTC
[GitHub] [skywalking-java] Cool-Coding opened a new pull request, #160: Remove redundant 'shade.package' property(#8904)
Cool-Coding opened a new pull request, #160:
URL: https://github.com/apache/skywalking-java/pull/160
### Fix <bug description or the bug issue number or bug issue link>
- [x] Explain briefly why the bug exists and how to fix it.
The `shade.package` property in `apm-sniffer/apm-agent-core/pom.xml` is redundant due to a legacy history reason. there weren't separate plugins jars, They were in the agent.jar as a whole in the past.
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://xueqiu.feishu.cn/docs/doccnEPUJ1d9C1SR6gEkCZF2HFb.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] Cool-Coding commented on pull request #160: Remove redundant 'shade.package' property(#8904)
Posted by GitBox <gi...@apache.org>.
Cool-Coding commented on PR #160:
URL: https://github.com/apache/skywalking-java/pull/160#issuecomment-1102165349
@wu-sheng The CI test has finished. As before ,there is still a dead link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #160: Remove redundant 'shade.package' property(#8904)
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #160:
URL: https://github.com/apache/skywalking-java/pull/160#issuecomment-1102173152
Don't worry. @kezhenxu94 fixed the main repo, Java repo is still TODO :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #160: Remove redundant 'shade.package' property(#8904)
Posted by GitBox <gi...@apache.org>.
wu-sheng merged PR #160:
URL: https://github.com/apache/skywalking-java/pull/160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org