You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/22 08:45:00 UTC

[GitHub] [hudi] yanghua opened a new pull request #3847: [HUDI-2600] Remove duplicated hadoop-common with tests classifier exists in bundles

yanghua opened a new pull request #3847:
URL: https://github.com/apache/hudi/pull/3847


   …
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #3847: [HUDI-2600][WIP] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #3847:
URL: https://github.com/apache/hudi/pull/3847#issuecomment-949551190


   @hudi-bot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on a change in pull request #3847: [HUDI-2600] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3847:
URL: https://github.com/apache/hudi/pull/3847#discussion_r735131259



##########
File path: dependencies/hudi-flink-bundle_2.11.txt
##########
@@ -107,14 +107,14 @@ force-shading/org.apache.flink/1.13.1//force-shading-1.13.1.jar
 grizzled-slf4j_2.11/org.clapper/1.3.2//grizzled-slf4j_2.11-1.3.2.jar
 groovy-all/org.codehaus.groovy/2.4.4//groovy-all-2.4.4.jar
 gson/com.google.code.gson/2.3.1//gson-2.3.1.jar
+guava/com.google.guava/12.0.1//guava-12.0.1.jar

Review comment:
       Currently, this PR only focuses on removing `hadoop-common` with the `tests` classifier. Other changes about dependencies like this are triggered by other commits that modified the pom file. Some governance may need to discuss, so it would be better to move into a single PR, IMO.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3847: [HUDI-2600][WIP] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3847:
URL: https://github.com/apache/hudi/pull/3847#issuecomment-949419768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2797",
       "triggerID" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "triggerType" : "PUSH"
     }, {
       "hash" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2799",
       "triggerID" : "949551190",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 09bec16fc3663bca8d0ddb1563fd02d58b723915 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2797) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2799) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3847: [HUDI-2600] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3847:
URL: https://github.com/apache/hudi/pull/3847#issuecomment-949419768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 09bec16fc3663bca8d0ddb1563fd02d58b723915 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3847: [HUDI-2600] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3847:
URL: https://github.com/apache/hudi/pull/3847#issuecomment-949419768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2797",
       "triggerID" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 09bec16fc3663bca8d0ddb1563fd02d58b723915 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2797) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on a change in pull request #3847: [HUDI-2600] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
xushiyan commented on a change in pull request #3847:
URL: https://github.com/apache/hudi/pull/3847#discussion_r735076092



##########
File path: dependencies/hudi-flink-bundle_2.11.txt
##########
@@ -107,14 +107,14 @@ force-shading/org.apache.flink/1.13.1//force-shading-1.13.1.jar
 grizzled-slf4j_2.11/org.clapper/1.3.2//grizzled-slf4j_2.11-1.3.2.jar
 groovy-all/org.codehaus.groovy/2.4.4//groovy-all-2.4.4.jar
 gson/com.google.code.gson/2.3.1//gson-2.3.1.jar
+guava/com.google.guava/12.0.1//guava-12.0.1.jar

Review comment:
       thought we removed guava dependency once?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3847: [HUDI-2600] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3847:
URL: https://github.com/apache/hudi/pull/3847#issuecomment-949419768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2797",
       "triggerID" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 09bec16fc3663bca8d0ddb1563fd02d58b723915 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2797) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot edited a comment on pull request #3847: [HUDI-2600][WIP] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3847:
URL: https://github.com/apache/hudi/pull/3847#issuecomment-949419768


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2797",
       "triggerID" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "triggerType" : "PUSH"
     }, {
       "hash" : "09bec16fc3663bca8d0ddb1563fd02d58b723915",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2799",
       "triggerID" : "949551190",
       "triggerType" : "MANUAL"
     } ]
   }-->
   ## CI report:
   
   * 09bec16fc3663bca8d0ddb1563fd02d58b723915 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2797) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2799) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run travis` re-run the last Travis build
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua merged pull request #3847: [HUDI-2600] Remove duplicated hadoop-common with tests classifier exists in bundles

Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #3847:
URL: https://github.com/apache/hudi/pull/3847


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org