Re: [PR] HDDS-11887. Recon - Identify container replicas difference based on content checksums [ozone]

["devmadhuu (via GitHub)" <gi...@apache.org>]

devmadhuu commented on code in PR #7942:
URL: https://github.com/apache/ozone/pull/7942#discussion_r1965565445


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java:
##########
@@ -650,6 +665,17 @@ private static boolean keepMisReplicatedRecord(
       return false;
     }
 
+    private static boolean keepReplicaMismatchRecord(
+            ContainerHealthStatus container, UnhealthyContainersRecord rec) {
+      if (container.isDataChecksumMismatched()) {
+        updateExpectedReplicaCount(rec, container.expectedPlacementCount());
+        updateActualReplicaCount(rec, container.actualPlacementCount());
+        updateReplicaDelta(rec, container.replicaDelta());

Review Comment:
   Update of expected replica count and actual replica count seems wrong here.



##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -424,6 +424,7 @@ message ContainerReplicaHistoryProto {
     required int64 lastSeenTime = 3;
     required int64 bcsId = 4;
     optional string state = 5;
+    optional int64 dataChecksum = 6;

Review Comment:
   Adding this new field in proto, will there be any decoding issues for existing data in `replica_history` table in upgrade case when try to load ? Has this been tested ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org