You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/23 09:34:16 UTC
[GitHub] [incubator-inlong] LvJiancheng opened a new pull request, #4313: [INLONG-4310] [Manager]manager-plugin support changes in sort entrance and jar
LvJiancheng opened a new pull request, #4313:
URL: https://github.com/apache/incubator-inlong/pull/4313
### Title Name: [INLONG-4310] [Manager]manager-plugin support changes in sort entrance and jar
where *XYZ* should be replaced by the actual issue number.
Fixes #4310
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve?*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4313: [INLONG-4310][Manager] Change the manager plugin to adapt the sort entrance and jar
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4313:
URL: https://github.com/apache/incubator-inlong/pull/4313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #4313: [INLONG-4310] [Manager]manager-plugin support changes in sort entrance and jar
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #4313:
URL: https://github.com/apache/incubator-inlong/pull/4313#discussion_r879231075
##########
inlong-distribution/distribution.xml:
##########
@@ -64,10 +64,10 @@
<!-- package InLong-Sort-->
<fileSet>
- <directory>../inlong-sort/sort-single-tenant/target</directory>
+ <directory>../inlong-sort/sort-dis/target</directory>
Review Comment:
sort-dis -> sort-dist
##########
inlong-distribution/distribution.xml:
##########
@@ -64,10 +64,10 @@
<!-- package InLong-Sort-->
<fileSet>
- <directory>../inlong-sort/sort-single-tenant/target</directory>
+ <directory>../inlong-sort/sort-dis/target</directory>
<outputDirectory>inlong-sort</outputDirectory>
<includes>
- <include>sort-single-tenant-${project.version}.jar</include>
+ <include>sort-dis-${project.version}.jar</include>
Review Comment:
sort-dis -> sort-dist
##########
inlong-manager/manager-plugins/src/main/java/org/apache/inlong/manager/plugin/flink/FlinkOperation.java:
##########
@@ -43,7 +43,7 @@ public class FlinkOperation {
+ "or task already terminated or savepoint path is null";
private static final String INLONG_MANAGER = "inlong-manager";
private static final String INLONG_SORT = "inlong-sort";
- private static final String SORT_JAR_PATTERN = "^sort-single-tenant.*jar$";
+ private static final String SORT_JAR_PATTERN = "^sort-dis.*jar$";
Review Comment:
sort-dis -> sort-dist
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org