You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/24 21:03:22 UTC
[GitHub] [spark] tgravescs opened a new pull request #27686: [SPARK-30942]
Fix the warning for requiring cores to be limiting resources
tgravescs opened a new pull request #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686
…urce
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
fix the warning for limiting resources when we don't know the number of executor cores. The issue is that there are places in the Spark code that use cores/task cpus to calculate slots and until the entire Stage level scheduling feature is in, we have to rely on the cores being the limiting resource.
Change the check to only warn when custom resources are specified.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
fix the check and warn when we should
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
A warning is printed
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
manually tested spark-shell with standalone mode, yarn, local mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590604406
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118885/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on a change in pull request #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#discussion_r383567558
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2798,7 +2798,7 @@ object SparkContext extends Logging {
defaultProf.maxTasksPerExecutor(sc.conf) < cpuSlots) {
throw new IllegalArgumentException("The number of slots on an executor has to be " +
"limited by the number of cores, otherwise you waste resources and " +
- "dynamic allocation doesn't work properly. Your configuration has " +
+ "some scheduling doesn't work properly. Your configuration has " +
Review comment:
I guess we should also update the comment above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27686: [SPARK-30942] Fix
the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-591210521
@tgravescs, I think we conventionally say who merged it and which branch it was merged to, even when it's obvious :-). Seems merged to master by you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #27686: [SPARK-30942] Fix the
warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27686: [SPARK-30942] Fix
the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590547753
Thank you, @tgravescs !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27686: [SPARK-30942] Fix
the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590593036
When you click `Details` button, you can see `rerun` button, @tgravescs . At this time, I clicked~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27686: [SPARK-30942]
Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590548951
**[Test build #118885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118885/testReport)** for PR 27686 at commit [`88789ef`](https://github.com/apache/spark/commit/88789ef6e8cae0147acf2c1a4ad369736fc0ba47).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590549436
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23634/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#discussion_r383934401
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2798,7 +2798,7 @@ object SparkContext extends Logging {
defaultProf.maxTasksPerExecutor(sc.conf) < cpuSlots) {
throw new IllegalArgumentException("The number of slots on an executor has to be " +
"limited by the number of cores, otherwise you waste resources and " +
- "dynamic allocation doesn't work properly. Your configuration has " +
+ "some scheduling doesn't work properly. Your configuration has " +
Review comment:
The comment above already says "dynamic allocation and scheduler ". I think that covers most of the cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27686: [SPARK-30942] Fix
the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590549436
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23634/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27686: [SPARK-30942] Fix the
warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590603805
**[Test build #118885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118885/testReport)** for PR 27686 at commit [`88789ef`](https://github.com/apache/spark/commit/88789ef6e8cae0147acf2c1a4ad369736fc0ba47).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on issue #27686: [SPARK-30942] Fix the
warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
tgravescs commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590547456
@HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590604395
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27686: [SPARK-30942] Fix
the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590549430
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590549430
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on issue #27686: [SPARK-30942] Fix the
warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
tgravescs commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590586744
error has nothing to do with this patch. @dongjoon-hyun how do I rerun the github action checks?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27686: [SPARK-30942] Fix
the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590604395
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#discussion_r383933236
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2798,7 +2798,7 @@ object SparkContext extends Logging {
defaultProf.maxTasksPerExecutor(sc.conf) < cpuSlots) {
throw new IllegalArgumentException("The number of slots on an executor has to be " +
"limited by the number of cores, otherwise you waste resources and " +
- "dynamic allocation doesn't work properly. Your configuration has " +
+ "some scheduling doesn't work properly. Your configuration has " +
Review comment:
I don't see the point of giving the examples, this is a temporary error that will go away when when the rest of the feature is put in. The end user just needs to know cores has to be limiting factor. All they need to know is spark won't work right if you don't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27686: [SPARK-30942] Fix the
warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590548951
**[Test build #118885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118885/testReport)** for PR 27686 at commit [`88789ef`](https://github.com/apache/spark/commit/88789ef6e8cae0147acf2c1a4ad369736fc0ba47).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#discussion_r383614812
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2798,7 +2798,7 @@ object SparkContext extends Logging {
defaultProf.maxTasksPerExecutor(sc.conf) < cpuSlots) {
throw new IllegalArgumentException("The number of slots on an executor has to be " +
"limited by the number of cores, otherwise you waste resources and " +
- "dynamic allocation doesn't work properly. Your configuration has " +
+ "some scheduling doesn't work properly. Your configuration has " +
Review comment:
Shall we give one or two examples for the "some scheduling" here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27686: [SPARK-30942] Fix
the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#issuecomment-590604406
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118885/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jiangxb1987 commented on a change in pull request #27686:
[SPARK-30942] Fix the warning for requiring cores to be limiting resources
Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on a change in pull request #27686: [SPARK-30942] Fix the warning for requiring cores to be limiting resources
URL: https://github.com/apache/spark/pull/27686#discussion_r383567558
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -2798,7 +2798,7 @@ object SparkContext extends Logging {
defaultProf.maxTasksPerExecutor(sc.conf) < cpuSlots) {
throw new IllegalArgumentException("The number of slots on an executor has to be " +
"limited by the number of cores, otherwise you waste resources and " +
- "dynamic allocation doesn't work properly. Your configuration has " +
+ "some scheduling doesn't work properly. Your configuration has " +
Review comment:
We should also update the comment above
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org