[GitHub] [superset] nytai commented on a change in pull request #13220: test: Switching FlashProvider to function component & creating tests

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #13220:
URL: https://github.com/apache/superset/pull/13220#discussion_r578785178



##########
File path: superset-frontend/src/views/App.tsx
##########
@@ -29,14 +27,13 @@ import { DynamicPluginProvider } from 'src/components/DynamicPlugins';
 import ErrorBoundary from 'src/components/ErrorBoundary';
 import Loading from 'src/components/Loading';
 import Menu from 'src/components/Menu/Menu';
-import FlashProvider from 'src/components/FlashProvider';
+import FlashProvider from 'src/components/FlashProvider/index';

Review comment:
       That's strange we have quite a few modules using this pattern already. You probably needed to restart your webpack server as it's probably pointing to an outdated module resolution cache for this file (happens when you don't change the path but do change the file structure). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org