You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/05 02:43:55 UTC
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request
#4603: add branch name explain for release guide.
cherrylzhao opened a new pull request #4603: add branch name explain for release guide.
URL: https://github.com/apache/incubator-shardingsphere/pull/4603
add this comment ` ${name} is the properly branch, e.g. master, dev-4.x`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4603: add
branch name explain for release guide.
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4603: add branch name explain for release guide.
URL: https://github.com/apache/incubator-shardingsphere/pull/4603
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #4603: add branch name explain for release guide.
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #4603: add branch name explain for release guide.
URL: https://github.com/apache/incubator-shardingsphere/pull/4603#discussion_r388078571
##########
File path: docs/community/content/contribute/release.cn.md
##########
@@ -135,7 +135,8 @@ https://github.com/apache/incubator-shardingsphere/blob/master/RELEASE-NOTES.md
创建`${RELEASE.VERSION}-release`分支，接下来的操作都在该分支进行。
```shell
-git clone -b ${branch} https://github.com/apache/incubator-shardingsphere.git ~/incubator-shardingsphere
+## ${name}为源码所在分支，如：master，dev-4.x
+git clone --branch ${name} https://github.com/apache/incubator-shardingsphere.git ~/incubator-shardingsphere
Review comment:
should add --depth=1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4603: add
branch name explain for release guide.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4603: add branch name explain for release guide.
URL: https://github.com/apache/incubator-shardingsphere/pull/4603#issuecomment-595009826
## Pull Request Test Coverage Report for [Build 10026](https://coveralls.io/builds/29141400)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.82%**
---
| Totals | [](https://coveralls.io/builds/29141400) |
| :-- | --: |
| Change from base [Build 10025](https://coveralls.io/builds/29141192): | 0.0% |
| Covered Lines: | 10399 |
| Relevant Lines: | 17985 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4603: add
branch name explain for release guide.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4603: add branch name explain for release guide.
URL: https://github.com/apache/incubator-shardingsphere/pull/4603#issuecomment-595008971
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=h1) Report
> Merging [#4603](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/b87a85e88a88bc4e3e46c44ea45281e00ac6383f?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4603 +/- ##
=========================================
Coverage 54.27% 54.27%
Complexity 343 343
=========================================
Files 1001 1001
Lines 17985 17985
Branches 3372 3372
=========================================
Hits 9761 9761
+ Misses 7601 7598 -3
- Partials 623 626 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...relation/statement/dml/SelectStatementContext.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3N0YXRlbWVudC9kbWwvU2VsZWN0U3RhdGVtZW50Q29udGV4dC5qYXZh) | `51.54% <0%> (-2.07%)` | `0% <0%> (ø)` | |
| [...re/sql/parser/relation/metadata/RelationMetas.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL21ldGFkYXRhL1JlbGF0aW9uTWV0YXMuamF2YQ==) | `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| [.../select/projection/impl/AggregationProjection.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXJlbGF0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcWwvcGFyc2VyL3JlbGF0aW9uL3NlZ21lbnQvc2VsZWN0L3Byb2plY3Rpb24vaW1wbC9BZ2dyZWdhdGlvblByb2plY3Rpb24uamF2YQ==) | `100% <0%> (+66.66%)` | `0% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=footer). Last update [b87a85e...97e9ae9](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4603: add branch name explain for release guide.
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4603: add branch name explain for release guide.
URL: https://github.com/apache/incubator-shardingsphere/pull/4603#issuecomment-595009826
## Pull Request Test Coverage Report for [Build 1982](https://coveralls.io/builds/29141811)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **2** unchanged lines in **1** file lost coverage.
* Overall coverage increased (+**0.006%**) to **57.826%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/29141811/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
<!-- | **Total:** | **2** | | -->
| Totals | [](https://coveralls.io/builds/29141811) |
| :-- | --: |
| Change from base [Build 10025](https://coveralls.io/builds/29141192): | 0.006% |
| Covered Lines: | 10400 |
| Relevant Lines: | 17985 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in
pull request #4603: add branch name explain for release guide.
Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #4603: add branch name explain for release guide.
URL: https://github.com/apache/incubator-shardingsphere/pull/4603#discussion_r388087430
##########
File path: docs/community/content/contribute/release.cn.md
##########
@@ -135,7 +135,8 @@ https://github.com/apache/incubator-shardingsphere/blob/master/RELEASE-NOTES.md
创建`${RELEASE.VERSION}-release`分支，接下来的操作都在该分支进行。
```shell
-git clone -b ${branch} https://github.com/apache/incubator-shardingsphere.git ~/incubator-shardingsphere
+## ${name}为源码所在分支，如：master，dev-4.x
+git clone --branch ${name} https://github.com/apache/incubator-shardingsphere.git ~/incubator-shardingsphere
Review comment:
`--depth=1` will lost history commits, it's not convenient for release-manager to check the download branch is right or not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services