You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/06/30 06:27:57 UTC
[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao opened a new pull request #147: [YUNIKORN-263] fix lint issues introduced in YUNIKORN-170
HuangTing-Yao opened a new pull request #147:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/147
Add `--skip-dirs` to the lint run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #147: [YUNIKORN-263] fix lint issues introduced in YUNIKORN-170
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #147:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao commented on pull request #147: [YUNIKORN-263] fix lint issues introduced in YUNIKORN-170
Posted by GitBox <gi...@apache.org>.
HuangTing-Yao commented on pull request #147:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/147#issuecomment-654579163
@wilfred-s I have already changed it as request, please help to review. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #147: [YUNIKORN-263] fix lint issues introduced in YUNIKORN-170
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #147:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/147#discussion_r448707430
##########
File path: .golangci.yml
##########
@@ -18,9 +18,13 @@
# options for analysis running
run:
issues-exit-code: 1
- skip-dirs-use-default: true
Review comment:
This is independent of what we specify in the `skip-dirs`: it specifies that the check should not be run against dir like vendor etc. We should leave it, just to not depend on the defaults from the code.
##########
File path: .golangci.yml
##########
@@ -18,9 +18,13 @@
# options for analysis running
run:
issues-exit-code: 1
- skip-dirs-use-default: true
modules-download-mode: readonly
deadline: 5m
+ skip-dirs:
+ - pkg/client/clientset
+ - pkg/client/informers
+ - pkg/client/listers
+ - pkg/apis/yunikorn.apache.org/v1alpha1/zz_generated.deepcopy.go
Review comment:
I tried this added an extra new line to the file and it did not get skipped.
Should this not be under `skip-files` (https://golangci-lint.run/usage/configuration/)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org