You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2020/03/10 20:35:01 UTC

[GitHub] [celix] pnoltes opened a new pull request #169: auto install then start bundles

pnoltes opened a new pull request #169: auto install then start bundles
URL: https://github.com/apache/celix/pull/169
 
 
   Changes auto start bundle handling to first installing and then starting bundles. In some cases this is preferred.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [celix] pnoltes merged pull request #169: auto install then start bundles

Posted by GitBox <gi...@apache.org>.
pnoltes merged pull request #169: auto install then start bundles
URL: https://github.com/apache/celix/pull/169
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [celix] pnoltes commented on a change in pull request #169: auto install then start bundles

Posted by GitBox <gi...@apache.org>.
pnoltes commented on a change in pull request #169: auto install then start bundles
URL: https://github.com/apache/celix/pull/169#discussion_r391190574
 
 

 ##########
 File path: cmake/cmake_celix/ContainerPackaging.cmake
 ##########
 @@ -408,7 +408,7 @@ endfunction()
 Add the selected bundles to the Celix container. These bundles are (if configured) copied to the container build dir and
 are added to the configuration properties so that they are installed and started when the Celix container executed.
 
-The Celix framework support 7 (0 - 6) run levels. Run levels can be used to control the start and stop order of bundles.
+The Celix framework supports 7 (0 - 6) run levels. Run levels can be used to control the start and stop order of bundles.
 
 Review comment:
   Yeah I think that is possible, but because the main function for a celix container is generated  with cmake (generator-expression), I am afraid this will be complex. So for now I would like to keep it at the fixed runtime levels.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [celix] abroekhuis commented on a change in pull request #169: auto install then start bundles

Posted by GitBox <gi...@apache.org>.
abroekhuis commented on a change in pull request #169: auto install then start bundles
URL: https://github.com/apache/celix/pull/169#discussion_r390806238
 
 

 ##########
 File path: cmake/cmake_celix/ContainerPackaging.cmake
 ##########
 @@ -408,7 +408,7 @@ endfunction()
 Add the selected bundles to the Celix container. These bundles are (if configured) copied to the container build dir and
 are added to the configuration properties so that they are installed and started when the Celix container executed.
 
-The Celix framework support 7 (0 - 6) run levels. Run levels can be used to control the start and stop order of bundles.
+The Celix framework supports 7 (0 - 6) run levels. Run levels can be used to control the start and stop order of bundles.
 
 Review comment:
   Is it possible to make this arbitrary? So that any number of levels is supported? Iirc in Java it is MAX_INT.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services