You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/06/08 12:45:56 UTC
Review Request 59913: AMBARI-21197 Disable Kerberos UI step by step
panel misalign with the Complete button at the bottom of the page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59913/
-----------------------------------------------------------
Review request for Ambari, Sangeeta Ravindran and Tim Thorpe.
Bugs: AMBARI-21197
https://issues.apache.org/jira/browse/AMBARI-21197
Repository: ambari
Description
-------
Disable Kerberos UI step by step panel misalign with the Complete button at the bottom of the page. See screenshot for details.
Diffs
-----
ambari-web/app/templates/common/progress.hbs ab59328
ambari-web/app/views/main/admin/kerberos/disable_view.js f7b3527
Diff: https://reviews.apache.org/r/59913/diff/1/
Testing
-------
existing unit tests. patch a trunk cluster, enable kerberos, verify the common progress pages have the correct width (via the new if/else logic), run disable kerberos, verify the progress page now has the correct width (via the new if/else logic)
Thanks,
Di Li
Re: Review Request 59913: AMBARI-21197 Disable Kerberos UI step by
step panel misalign with the Complete button at the bottom of the page
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59913/#review177310
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On June 8, 2017, 12:45 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59913/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 12:45 p.m.)
>
>
> Review request for Ambari, Sangeeta Ravindran and Tim Thorpe.
>
>
> Bugs: AMBARI-21197
> https://issues.apache.org/jira/browse/AMBARI-21197
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Disable Kerberos UI step by step panel misalign with the Complete button at the bottom of the page. See screenshot for details.
>
>
> Diffs
> -----
>
> ambari-web/app/templates/common/progress.hbs ab59328
> ambari-web/app/views/main/admin/kerberos/disable_view.js f7b3527
>
>
> Diff: https://reviews.apache.org/r/59913/diff/1/
>
>
> Testing
> -------
>
> existing unit tests. patch a trunk cluster, enable kerberos, verify the common progress pages have the correct width (via the new if/else logic), run disable kerberos, verify the progress page now has the correct width (via the new if/else logic)
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 59913: AMBARI-21197 Disable Kerberos UI step by
step panel misalign with the Complete button at the bottom of the page
Posted by Sangeeta Ravindran <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59913/#review177327
-----------------------------------------------------------
Ship it!
Ship It!
- Sangeeta Ravindran
On June 8, 2017, 12:45 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59913/
> -----------------------------------------------------------
>
> (Updated June 8, 2017, 12:45 p.m.)
>
>
> Review request for Ambari, Sangeeta Ravindran and Tim Thorpe.
>
>
> Bugs: AMBARI-21197
> https://issues.apache.org/jira/browse/AMBARI-21197
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Disable Kerberos UI step by step panel misalign with the Complete button at the bottom of the page. See screenshot for details.
>
>
> Diffs
> -----
>
> ambari-web/app/templates/common/progress.hbs ab59328
> ambari-web/app/views/main/admin/kerberos/disable_view.js f7b3527
>
>
> Diff: https://reviews.apache.org/r/59913/diff/1/
>
>
> Testing
> -------
>
> existing unit tests. patch a trunk cluster, enable kerberos, verify the common progress pages have the correct width (via the new if/else logic), run disable kerberos, verify the progress page now has the correct width (via the new if/else logic)
>
>
> Thanks,
>
> Di Li
>
>