You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by jw...@apache.org on 2013/11/05 23:14:44 UTC

svn commit: r1539162 - /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java

Author: jwaldman
Date: Tue Nov  5 22:14:43 2013
New Revision: 1539162

URL: http://svn.apache.org/r1539162
Log:
TRINIDAD-2423 wrong assertion for font-size that it should be numeric
Thanks to Anand Nath for the patch

Modified:
    myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java

Modified: myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java?rev=1539162&r1=1539161&r2=1539162&view=diff
==============================================================================
--- myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java (original)
+++ myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/style/xml/parse/StyleSheetDocument.java Tue Nov  5 22:14:43 2013
@@ -1285,7 +1285,10 @@ public class StyleSheetDocument
     }
     catch (NumberFormatException e)
     {
-      assert false:"Could not parse font size: " + value;
+      // there are valid values like small, large etc for font-size
+      // we do not have to process those
+      // so just log this and return the original PropertyNode
+      _LOG.fine("Could not parse font size: " + value + ". Returning the property as is.");
 
       return property;
     }