[jira] [Updated] (SOLR-10558) Support unlimited limits on ChildDocTransformer

["Jason Gerlowski (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-10558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Gerlowski updated SOLR-10558:
-----------------------------------
    Attachment: SOLR-10558.patch

I've attached a small patch showing one way this change could be done.  In it, any negative "limit" param is treated as a flag value, and the limit is effectively disabled by using {{Integer.MAX_VALUE}} as the limit value.  This is really just an internalization of the current workaround the reporter mentioned above.

(Another way to handle this would have been to create a {{SolrIndexSearcher}} method which doesn't take a limit at all, but that seemed like a big change for what we're trying to accomplish here.)

All tests pass locally

> Support unlimited limits on ChildDocTransformer
> -----------------------------------------------
>
>                 Key: SOLR-10558
>                 URL: https://issues.apache.org/jira/browse/SOLR-10558
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 4.10.4
>            Reporter: Tero Paananen
>            Priority: Minor
>         Attachments: SOLR-10558.patch
>
>
> The ChildDocTransformer has a limit on a number of child documents returned per parent document. The default is set to 10.
> We have a use case where we need to return all child documents.
> The current workaround is to set the limit to a number so high it's unlikely any parent document ever would have that many child documents. It would be less error prone if the limit could be set to "unlimited".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org