You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/10 03:48:02 UTC

[GitHub] [dolphinscheduler] sketchmind commented on a diff in pull request #11372: [Feature-10117][UI] Hide node execution when start from the workflow definition list page

sketchmind commented on code in PR #11372:
URL: https://github.com/apache/dolphinscheduler/pull/11372#discussion_r941989142


##########
dolphinscheduler-ui/src/views/projects/workflow/definition/components/start-modal.tsx:
##########
@@ -144,6 +147,11 @@ export default defineComponent({
       }
     ]
 
+    const showTaskDependType = computed(() =>
+      (route.name === 'workflow-definition-detail' ||
+        route.name === 'workflow-instance-detail')
+    )
+

Review Comment:
   > Is this only displayed on page workflow definition detail? because the start action is not supported on workflow instance detail page.
   
   Ok, i'll make some changes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org