[GitHub] eiri opened a new issue #1236: Fix should_add_user_to_db_admins test suite

[GitBox <gi...@apache.org>]

eiri opened a new issue #1236: Fix should_add_user_to_db_admins test suite
URL: https://github.com/apache/couchdb/issues/1236
 
 
   Test should_add_user_to_db_admins is horribly unreliable. Current master from travis:
   
   ```
   in function couch_peruser_test:'-should_add_user_to_db_admins/1-fun-0-'/0 (test/couch_peruser_test.erl, line 321)
   **error:{assertEqual,[{module,couch_peruser_test},
                 {line,321},
                 {expression,"proplists : get_value ( << \"admins\" >> , get_security ( UserDbName ) )"},
                 {expected,{[{<<"names">>,[<<"qux">>]}]}},
                 {value,undefined}]}
     output:<<"">>
   ```
   
   ## Expected Behavior
   Test shouldn't break on a whim for unrelated changes
   
   ## Current Behavior
   There are obvious race in that test and it is plaguing us for longer than half-year, if one can trust search on closed PRs claiming to fix it.
   
   ## Possible Solution
   Find and fix that annoying race. 
   
   ## Steps to Reproduce (for bugs)
   Dunno, it's a race. Run suite enough times to catch it? Insert timers in random parts to induce it?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services