You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/30 15:55:16 UTC

[GitHub] [rocketmq-dashboard] xxd763795151 opened a new pull request #71: [ISSUE #70] The rocketmq-dashboard supports ACL configuration

xxd763795151 opened a new pull request #71:
URL: https://github.com/apache/rocketmq-dashboard/pull/71

## What is the purpose of the change
The rocketmq-dashboard supports ACL configuration, such as following:
![image](https://user-images.githubusercontent.com/19887530/151706043-89065aa9-12bb-47d6-9759-6dffa8250a4d.png)
Or
![image](https://user-images.githubusercontent.com/19887530/151706240-f52b6ffe-7575-42ba-836a-c470686f8751.png)

Feature descirbe:
* the 'CRUD operation' of topic permission for an accessKey
* the 'CRUD operation' of group permission for an accessKey
* add/delete host white list
* the acl info can be synchronized in the cluster from a broker to all broker when it is inconsistent(Why it may be inconsistent? For example, the acl info is add by manual in all brokers, one broker config error or forget to config; when we config acl, one broker is down in the cluster.)

**Note: the Acl menu only appears when the accessKey and secretKey is not empty in the application.yml. **

By the way, the last topic or group permission can not be deleted if there is only one topic or group permission for an access key because of the rocketmq`s implemention.

## Brief changelog

XXXX

## Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org