You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by zwoop <gi...@git.apache.org> on 2016/11/01 14:27:18 UTC
[GitHub] trafficserver pull request #1166: TS-5024: Limits the gzip to 200 OK respons...
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1166
TS-5024: Limits the gzip to 200 OK responses
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver TS-5024
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1166
----
commit f1e5c2e889cefe99ebe38ee65d0cb37121ed635e
Author: Leif Hedstrom <zw...@apache.org>
Date: 2016-11-01T14:25:07Z
TS-5024: Limits the gzip to 200 OK responses
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1166: TS-5024: Limits the gzip to 200 OK respons...
Posted by oschaaf <gi...@git.apache.org>.
Github user oschaaf commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1166#discussion_r85942529
--- Diff: plugins/gzip/gzip.cc ---
@@ -480,8 +480,8 @@ gzip_transformable(TSHttpTxn txnp, bool server, HostConfiguration *host_configur
resp_status = TSHttpHdrStatusGet(bufp, hdr_loc);
- // conservatively pick some statusses to compress
- if (!(resp_status == 200 || resp_status == 404 || resp_status == 500)) {
+ // conservatively pick some statusses to compress. ToDo: Make this configurable?
+ if (resp_status != 200) {
--- End diff --
This seems like a good change to me, it's the probably safer default -- but is it possible that we see `200/OK` two times here when the HttpSM is restarted?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1166: TS-5024: Limits the gzip to 200 OK responses
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1166
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1133/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1166: TS-5024: Limits the gzip to 200 OK respons...
Posted by oschaaf <gi...@git.apache.org>.
Github user oschaaf commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1166#discussion_r85982067
--- Diff: plugins/gzip/gzip.cc ---
@@ -480,8 +480,8 @@ gzip_transformable(TSHttpTxn txnp, bool server, HostConfiguration *host_configur
resp_status = TSHttpHdrStatusGet(bufp, hdr_loc);
- // conservatively pick some statusses to compress
- if (!(resp_status == 200 || resp_status == 404 || resp_status == 500)) {
+ // conservatively pick some statusses to compress. ToDo: Make this configurable?
+ if (resp_status != 200) {
--- End diff --
I see. LGTM, no more questions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1166: TS-5024: Limits the gzip to 200 OK respons...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1166#discussion_r85968661
--- Diff: plugins/gzip/gzip.cc ---
@@ -480,8 +480,8 @@ gzip_transformable(TSHttpTxn txnp, bool server, HostConfiguration *host_configur
resp_status = TSHttpHdrStatusGet(bufp, hdr_loc);
- // conservatively pick some statusses to compress
- if (!(resp_status == 200 || resp_status == 404 || resp_status == 500)) {
+ // conservatively pick some statusses to compress. ToDo: Make this configurable?
+ if (resp_status != 200) {
--- End diff --
@oschaaf It is *possible*, but unlikely. The immediate issues we're having is that gzip works very poorly together with the escalate plugin, but you wouldn't escalate on a 200 OK. Long term, @meeramn is going to add a new plugin API, that enforces uniqueness on the continuations added to a hook.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #1166: TS-5024: Limits the gzip to 200 OK respons...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #1166: TS-5024: Limits the gzip to 200 OK responses
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/1166
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/1027/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---