You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@freemarker.apache.org by dd...@apache.org on 2020/08/03 23:03:55 UTC

[freemarker-docgen] 04/04: Fixed issue where the left ToC may stayed hidden when going from mobile view to normal view.

This is an automated email from the ASF dual-hosted git repository.

ddekany pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/freemarker-docgen.git

commit b775e8640188baf068d6a9ad49face4569f952cb
Author: ddekany <dd...@apache.org>
AuthorDate: Sun Aug 2 16:32:38 2020 +0200

    Fixed issue where the left ToC may stayed hidden when going from mobile view to normal view.
---
 .../resources-gulp/org/freemarker/docgen/core/js/page-menu.js  | 10 +++-------
 .../org/freemarker/docgen/core/less/lib/layout/content.less    |  6 ++++--
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/js/page-menu.js b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/js/page-menu.js
index 8f8e2b7..b731d7d 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/js/page-menu.js
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/js/page-menu.js
@@ -56,13 +56,9 @@
     if (node.classList.contains('page-menu-link')) {
       highlightNode(node.getAttribute('data-menu-target'));
     } else if (node.id == 'hamburger-menu') {
-      if (toc.style.display === "block") {
-        toc.style.display = "none";
-      } else {
-        toc.style.display = "block";
-      }
-    } else if (toc.style.display === "block" && !toc.contains(event.target)) {
-      toc.style.display = "none";
+      toc.classList.toggle("visible-hamburger-menu");
+    } else if (toc.classList.contains("visible-hamburger-menu") && !toc.contains(event.target)) {
+      toc.classList.remove("visible-hamburger-menu");
     }
   }
 
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/content.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/content.less
index 38de2ae..3c2e087 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/content.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/content.less
@@ -39,8 +39,11 @@
   }
 
   #table-of-contents-wrapper {
-    // Hide for typical mobile screens:
+    // Hide for typical mobile screens initially:
     display: none;
+    &.visible-hamburger-menu {
+      display: block;
+    }
 
     @media (min-width: @screen-xs-min) {
       display: block;
@@ -88,7 +91,6 @@
   .col-right {
     flex: 1;
     position: relative; // so we can position bottom pager
-
   }
 }