You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/12 09:17:02 UTC
[GitHub] [dubbo-go] zhaoyunxing92 commented on a change in pull request #1516: Update triple and some relies version, add consumer registry timeout configuration item
zhaoyunxing92 commented on a change in pull request #1516:
URL: https://github.com/apache/dubbo-go/pull/1516#discussion_r726926282
##########
File path: config/consumer_config.go
##########
@@ -50,7 +48,8 @@ type ConsumerConfig struct {
References map[string]*ReferenceConfig `yaml:"references" json:"references,omitempty" property:"references"`
- FilterConf interface{} `yaml:"filter-conf" json:"filter-conf,omitempty" property:"filter-conf"`
+ FilterConf interface{} `yaml:"filter-conf" json:"filter-conf,omitempty" property:"filter-conf"`
Review comment:
1.下划线是不是要改横线
2.为什么要添加这个key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org