You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dengziming (via GitHub)" <gi...@apache.org> on 2023/11/11 07:47:59 UTC
[PR] [SPARK-43258][SQL] Assign names to error _LEGACY_ERROR_TEMP_202[3,4,5] [spark]
dengziming opened a new pull request, #43764:
URL: https://github.com/apache/spark/pull/43764
### What changes were proposed in this pull request?
1. Assign the name `NOT_A_UNRESOLVED_ENCODER` to the legacy error class `_LEGACY_ERROR_TEMP_2023`;
2. Assign the name `UNSUPPORTED_ENCODER` to the legacy error class `_LEGACY_ERROR_TEMP_2024`;
3. Assign the name `CLASS_NOT_OVERRIDE_EXPECTED_METHOD` to the legacy error class `_LEGACY_ERROR_TEMP_2025`;
### Why are the changes needed?
To assign proper name as a part of activity in SPARK-37935.
### Does this PR introduce _any_ user-facing change?
Yes, the error message will include the error class name.
### How was this patch tested?
Test cases in `QueryExecutionErrorsSuite.scala`.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43258][SQL] Assign names to error _LEGACY_ERROR_TEMP_202[3,4,5] [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43764:
URL: https://github.com/apache/spark/pull/43764#issuecomment-1953304302
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43258][SQL] Assign names to error _LEGACY_ERROR_TEMP_202[3,4,5] [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #43764:
URL: https://github.com/apache/spark/pull/43764#issuecomment-1954183303
@dengziming Are you still working on the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43258][SQL] Assign names to error _LEGACY_ERROR_TEMP_202[3,4,5] [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #43764: [SPARK-43258][SQL] Assign names to error _LEGACY_ERROR_TEMP_202[3,4,5]
URL: https://github.com/apache/spark/pull/43764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43258][SQL] Assign names to error _LEGACY_ERROR_TEMP_202[3,4,5] [spark]
Posted by "MaxGekk (via GitHub)" <gi...@apache.org>.
MaxGekk commented on PR #43764:
URL: https://github.com/apache/spark/pull/43764#issuecomment-1961024077
@dengziming I cannot reopen it. Could you create new PR.
<img width="358" alt="Screenshot 2024-02-23 at 12 51 16" src="https://github.com/apache/spark/assets/1580697/a6eae09f-b183-4fc6-958a-134e0dbe989c">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43258][SQL] Assign names to error _LEGACY_ERROR_TEMP_202[3,4,5] [spark]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on PR #43764:
URL: https://github.com/apache/spark/pull/43764#issuecomment-1961001969
Hi @MaxGekk can you help reopen this PR? I have rebased this PR on the master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-43258][SQL] Assign names to error _LEGACY_ERROR_TEMP_202[3,4,5] [spark]
Posted by "dengziming (via GitHub)" <gi...@apache.org>.
dengziming commented on PR #43764:
URL: https://github.com/apache/spark/pull/43764#issuecomment-1955755532
@MaxGekk Sure, I'm still following up on this PR, I will rebase it on the master soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org