You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org> on 2017/09/12 13:05:00 UTC
[jira] [Resolved] (RANGER-1732) Collection added to itself
[ https://issues.apache.org/jira/browse/RANGER-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colm O hEigeartaigh resolved RANGER-1732.
-----------------------------------------
Resolution: Fixed
> Collection added to itself
> --------------------------
>
> Key: RANGER-1732
> URL: https://issues.apache.org/jira/browse/RANGER-1732
> Project: Ranger
> Issue Type: Bug
> Components: audit
> Reporter: JC
> Assignee: peng.jianhua
> Priority: Trivial
> Fix For: 1.0.0, 0.7.2
>
> Attachments: 0001-RANGER-1732-Collection-added-to-itsel.patch
>
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: master
> Path: agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java
> {code:java}
> 32 Collection<AuthzAuditEvent> auditEvents = new ArrayList<>();
> ...
> 42
> 43 @Override
> 44 public void logAuthzAudits(Collection<AuthzAuditEvent> auditEvents) {
> 45 auditEvents.addAll(auditEvents);
> 46 }
> {code}
> In Line 45, `auditEvents.addAll' should be `this.auditEvents.addAll'? This might not be an issue but I wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)