[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #458: [ISSUE-378][HugePartition][1/n] Record every partition data size for one app

[GitBox <gi...@apache.org>]

zuston commented on code in PR #458:
URL: https://github.com/apache/incubator-uniffle/pull/458#discussion_r1063368084


##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskInfo.java:
##########
@@ -46,13 +47,20 @@ public class ShuffleTaskInfo {
 
   private AtomicReference<ShuffleDataDistributionType> dataDistType;
 
+  private AtomicLong totalDataSize = new AtomicLong(0);
+  /**
+   * shuffleId -> partitionId -> partition shuffle data size
+   */
+  private Map<Integer, Map<Integer, Long>> partitionDataSizes;

Review Comment:
   It will be added by the `ConcurrentHashMap.computeIfPresent,` this is a thread safe operation. Right? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org