[jira] [Commented] (KNOX-642) Add documentation for pac4j provider

["Larry McCay (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KNOX-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102567#comment-15102567 ] 

Larry McCay commented on KNOX-642:
----------------------------------

I think that the latest patch is pretty good.
I like how each major flavor is broken out separately and the links to the pac4j docs.

If you don't have any objections, I would like to make some minor changes to it as it stands to further describe the parameters that gave me some confusion and probably to remove the SSOCookieProvider from the pac4j provider docs. While they are complementary the former is not required for all uses of KnoxSSO (only for REST API access). We will need tutorials that combine such things together into meaningful usecases instead of trying to cover all combinations in the pac4j provider.

This is a great start and I think almost ready to commit though!

I'd like to thank you again for this work.

> Add documentation for pac4j provider
> ------------------------------------
>
>                 Key: KNOX-642
>                 URL: https://issues.apache.org/jira/browse/KNOX-642
>             Project: Apache Knox
>          Issue Type: Task
>            Reporter: Jérôme Leleu
>            Assignee: Jérôme Leleu
>             Fix For: 0.8.0
>
>         Attachments: KNOX-642.patch, knox642.patch2, knox642.patch3
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)