You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "joeljohansson99 (via GitHub)" <gi...@apache.org> on 2025/01/13 12:52:08 UTC
[PR] Abstract revoked key handling in KnownHostsServerKeyVerifier [mina-sshd]
joeljohansson99 opened a new pull request, #653:
URL: https://github.com/apache/mina-sshd/pull/653
Abstract handling of revoked key so extending classes has an easier way to add functionality when a matching host entry has a 'revoked' marker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Abstract revoked key handling in KnownHostsServerKeyVerifier [mina-sshd]
Posted by "joeljohansson99 (via GitHub)" <gi...@apache.org>.
joeljohansson99 commented on PR #653:
URL: https://github.com/apache/mina-sshd/pull/653#issuecomment-2589784267
I moved the debug logging. Think it makes sense too. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Abstract revoked key handling in KnownHostsServerKeyVerifier [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on code in PR #653:
URL: https://github.com/apache/mina-sshd/pull/653#discussion_r1914484475
##########
sshd-core/src/main/java/org/apache/sshd/client/keyverifier/KnownHostsServerKeyVerifier.java:
##########
@@ -536,6 +537,16 @@ protected List<HostEntryPair> findKnownHostEntries(
return matches;
}
+ /**
+ * Invoked if any matching host entry has a 'revoked' marker
+ *
+ * @param clientSession The {@link ClientSession}
+ * @param remoteAddress The remote host address
+ * @param serverKey The presented server {@link PublicKey}
+ */
+ protected void handleRevokedKey(ClientSession clientSession, SocketAddress remoteAddress, PublicKey serverKey) {
+ }
Review Comment:
Now PMD is unhappy about this empty block.
Either insert a comment `// By default do nothing`, or move the debug logging from before the call into this body. The latter might make sense; if someone overrides this, he can then decide whether to have that debug logging (call super) or not (don't call super, do something else entirely).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Abstract revoked key handling in KnownHostsServerKeyVerifier [mina-sshd]
Posted by "joeljohansson99 (via GitHub)" <gi...@apache.org>.
joeljohansson99 commented on PR #653:
URL: https://github.com/apache/mina-sshd/pull/653#issuecomment-2589278725
Hi Thomas, thanks for the feedback. I ran the formatting, and committed. I did not get the amend to work, hope that is alright.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Abstract revoked key handling in KnownHostsServerKeyVerifier [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf merged PR #653:
URL: https://github.com/apache/mina-sshd/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [PR] Abstract revoked key handling in KnownHostsServerKeyVerifier [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on PR #653:
URL: https://github.com/apache/mina-sshd/pull/653#issuecomment-2587456680
The formatter is not happy. Run a local maven build; it'll reformat the file. Then commit (amend) the result and force push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org