You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/04/13 05:09:26 UTC
[GitHub] [commons-math] arturobernalg opened a new pull request #176: MATH-1572 - Simplify Conditions:
arturobernalg opened a new pull request #176:
URL: https://github.com/apache/commons-math/pull/176
* Simplifiable boolean expression
* Simplifiable conditional expression
* Redundant 'if' statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-math] arturobernalg closed pull request #176: MATH-1572 - Simplify Conditions:
Posted by GitBox <gi...@apache.org>.
arturobernalg closed pull request #176:
URL: https://github.com/apache/commons-math/pull/176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-math] coveralls commented on pull request #176: MATH-1572 - Simplify Conditions:
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #176:
URL: https://github.com/apache/commons-math/pull/176#issuecomment-818568231
[](https://coveralls.io/builds/38760875)
Coverage increased (+0.02%) to 90.718% when pulling **59493b672b334a2e6d7f9f37084a8df0b3e308e0 on arturobernalg:feature/MATH-1572** into **26511237d21026623bc7ff26a1d2e90f16f21325 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-math] msrocka commented on a change in pull request #176: MATH-1572 - Simplify Conditions:
Posted by GitBox <gi...@apache.org>.
msrocka commented on a change in pull request #176:
URL: https://github.com/apache/commons-math/pull/176#discussion_r623715426
##########
File path: src/main/java/org/apache/commons/math4/stat/inference/KolmogorovSmirnovTest.java
##########
@@ -1133,11 +1133,7 @@ private static boolean hasTies(double[] x, double[] y) {
throw new InsufficientDataException();
}
- if (values.length == x.length + y.length) {
- return false; // There are no ties.
- }
-
- return true;
+ return values.length != x.length + y.length; // There are no ties.
Review comment:
The comment is then wrong, isn't it? Before it checked if there are no ties (`values.length == x.length + y.length`) and the comment was related to the `false` return value. Now it directly checks if there are ties which is basically the name of the method so that the comment could be simply removed, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-math] coveralls edited a comment on pull request #176: MATH-1572 - Simplify Conditions:
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #176:
URL: https://github.com/apache/commons-math/pull/176#issuecomment-818568231
[](https://coveralls.io/builds/38774338)
Coverage increased (+0.01%) to 90.717% when pulling **904abc0a76cf8a8ad803e6b0693b09de452df893 on arturobernalg:feature/MATH-1572** into **e29fd602381be65c0e2c2e4cd1e1c59bfa16c8bd on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org