You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Mark Chu-Carroll <mc...@twitter.com> on 2013/12/17 19:15:27 UTC
Review Request 16326: Fix thermos glitch in aurora-12.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16326/
-----------------------------------------------------------
Review request for Aurora and Brian Wickman.
Bugs: aurora-12
https://issues.apache.org/jira/browse/aurora-12
Repository: aurora
Description
-------
Fix thermos glitch in aurora-12:
The task list used by the command line was returned as an iterator, but used as a list.
Diffs
-----
src/main/python/twitter/thermos/bin/thermos.py 39ab1f24a615a8d0cafb571cd463fd8b5ba24f70
Diff: https://reviews.apache.org/r/16326/diff/
Testing
-------
Ran all unit tests.
Thanks,
Mark Chu-Carroll
Re: Review Request 16326: Fix thermos glitch in aurora-12.
Posted by Brian Wickman <wi...@gmail.com>.
merged
On Tue, Dec 17, 2013 at 11:08 AM, Mark Chu-Carroll
<mc...@twitter.com>wrote:
> Thanks for the review. I still can't ship it myself - so can you either
> push it, or ask someone in SF with commit rights to do it?
>
> Thanks!
>
> -Mark
>
>
> On Tue, Dec 17, 2013 at 1:58 PM, Brian Wickman <wi...@gmail.com> wrote:
>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/16326/
>>
>> Ship it!
>>
>> Ship It!
>>
>>
>> - Brian Wickman
>>
>> On December 17th, 2013, 6:15 p.m. UTC, Mark Chu-Carroll wrote:
>> Review request for Aurora and Brian Wickman.
>> By Mark Chu-Carroll.
>>
>> *Updated Dec. 17, 2013, 6:15 p.m.*
>> *Bugs: * aurora-12 <https://issues.apache.org/jira/browse/aurora-12>
>> *Repository: * aurora
>> Description
>>
>> Fix thermos glitch in aurora-12:
>>
>> The task list used by the command line was returned as an iterator, but used as a list.
>>
>> Testing
>>
>> Ran all unit tests.
>>
>> Diffs
>>
>> - src/main/python/twitter/thermos/bin/thermos.py
>> (39ab1f24a615a8d0cafb571cd463fd8b5ba24f70)
>>
>> View Diff <https://reviews.apache.org/r/16326/diff/>
>>
>
>
>
> --
> Mark Craig Chu-Carroll
> *** Software Engineer@Twitter, Software Tools/Programming Language/Math
> Geek
> *** Email:mchucarroll@twitter.com / markcc@gmail.com
> *** Blog: http://scientopia.org/blogs/goodmath
>
Re: Review Request 16326: Fix thermos glitch in aurora-12.
Posted by Mark Chu-Carroll <mc...@twitter.com>.
Thanks for the review. I still can't ship it myself - so can you either
push it, or ask someone in SF with commit rights to do it?
Thanks!
-Mark
On Tue, Dec 17, 2013 at 1:58 PM, Brian Wickman <wi...@gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16326/
>
> Ship it!
>
> Ship It!
>
>
> - Brian Wickman
>
> On December 17th, 2013, 6:15 p.m. UTC, Mark Chu-Carroll wrote:
> Review request for Aurora and Brian Wickman.
> By Mark Chu-Carroll.
>
> *Updated Dec. 17, 2013, 6:15 p.m.*
> *Bugs: * aurora-12 <https://issues.apache.org/jira/browse/aurora-12>
> *Repository: * aurora
> Description
>
> Fix thermos glitch in aurora-12:
>
> The task list used by the command line was returned as an iterator, but used as a list.
>
> Testing
>
> Ran all unit tests.
>
> Diffs
>
> - src/main/python/twitter/thermos/bin/thermos.py
> (39ab1f24a615a8d0cafb571cd463fd8b5ba24f70)
>
> View Diff <https://reviews.apache.org/r/16326/diff/>
>
--
Mark Craig Chu-Carroll
*** Software Engineer@Twitter, Software Tools/Programming Language/Math Geek
*** Email:mchucarroll@twitter.com / markcc@gmail.com
*** Blog: http://scientopia.org/blogs/goodmath
Re: Review Request 16326: Fix thermos glitch in aurora-12.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16326/#review30552
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Dec. 17, 2013, 6:15 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16326/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 6:15 p.m.)
>
>
> Review request for Aurora and Brian Wickman.
>
>
> Bugs: aurora-12
> https://issues.apache.org/jira/browse/aurora-12
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix thermos glitch in aurora-12:
>
> The task list used by the command line was returned as an iterator, but used as a list.
>
>
> Diffs
> -----
>
> src/main/python/twitter/thermos/bin/thermos.py 39ab1f24a615a8d0cafb571cd463fd8b5ba24f70
>
> Diff: https://reviews.apache.org/r/16326/diff/
>
>
> Testing
> -------
>
> Ran all unit tests.
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>