You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/29 08:38:38 UTC
[GitHub] [pulsar] Celebrate-future opened a new pull request #14924: remove redundant dependencies
Celebrate-future opened a new pull request #14924:
URL: https://github.com/apache/pulsar/pull/14924
Hi! I found the pom file of project **_org.apache.pulsar:buildtools:2.10.0-SNAPSHOT_** introduced **_28_** dependencies. However, among them, **_5_** libraries (**_17%_**) are not used by your project. I list the redundant dependencies below (labelled as red ones in the figure):
## Redundant dependencies
com.google.guava:listenablefuture:jar:9999.0-empty-to-avoid-conflict-with-guava:compile
com.google.code.findbugs:jsr305:jar:3.0.2:compile
com.google.errorprone:error_prone_annotations:jar:2.7.1:compile
com.google.j2objc:j2objc-annotations:jar:1.3:compile
javax.inject:javax.inject:jar:1:compile
---
Removing the redundant dependencies can reduce the size of project and prevent potential dependency conflict issues (i.e., multiple versions of the same library). More importantly, one of the redundant dependencies **_javax.inject:javax.inject:jar:1:compile_** induced dependency conflict in the dependency graph. As such, I suggest a refactoring operation for **_org.apache.pulsar:buildtools:2.10.0-SNAPSHOT_**’s pom file.
The attached PR helps resolve the reported problem. It is safe to remove the unused libraries (we considered Java reflection relations when analyzing the dependencies). These changes have passed **_org.apache.pulsar:buildtools:2.10.0-SNAPSHOT_**’s maven tests.
Best regards
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] HQebupt commented on pull request #14924: Could org.apache.pulsar:buildtools:2.10.0-SNAPSHOT drop off redundant dependencies?
Posted by GitBox <gi...@apache.org>.
HQebupt commented on pull request #14924:
URL: https://github.com/apache/pulsar/pull/14924#issuecomment-1086588168
Thanks for your contribution. Please refer the [PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Celebrate-future commented on pull request #14924: Could org.apache.pulsar:buildtools:2.10.0-SNAPSHOT drop off redundant dependencies?
Posted by GitBox <gi...@apache.org>.
Celebrate-future commented on pull request #14924:
URL: https://github.com/apache/pulsar/pull/14924#issuecomment-1086599152
> 感谢您的贡献。请参阅 [PR 命名约定](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35)。
> Thanks for your contribution. Please refer the [PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35).
OK，I will finish it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14924: Could org.apache.pulsar:buildtools:2.10.0-SNAPSHOT drop off redundant dependencies?
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14924:
URL: https://github.com/apache/pulsar/pull/14924#issuecomment-1081685909
@Celebrate-future:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org