[GitHub] [pulsar] Jason918 commented on a change in pull request #14727: when consumer close and create frequently, delay message will be duplicated

[GitBox <gi...@apache.org>]

Jason918 commented on a change in pull request #14727:
URL: https://github.com/apache/pulsar/pull/14727#discussion_r830460166



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
##########
@@ -480,6 +481,7 @@ public synchronized void readEntriesComplete(List<Entry> entries, Object ctx) {
             // All consumers got disconnected before the completion of the read operation
             entries.forEach(Entry::release);
             cursor.rewind();
+            clearDelayedMessages();

Review comment:
       If `clearDelayedMessages()` binds with `cursor.rewind()`, it's better to wrap them into one method.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org