You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Markus Weimer (JIRA)" <ji...@apache.org> on 2016/05/12 01:14:13 UTC

[jira] [Resolved] (REEF-1379) Add a fluid interface to EvaluatorRequestor

     [ https://issues.apache.org/jira/browse/REEF-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Markus Weimer resolved REEF-1379.
---------------------------------
       Resolution: Fixed
    Fix Version/s: 0.15

Resolved via [#993|https://github.com/apache/reef/pull/993]

> Add a fluid interface to EvaluatorRequestor
> -------------------------------------------
>
>                 Key: REEF-1379
>                 URL: https://issues.apache.org/jira/browse/REEF-1379
>             Project: REEF
>          Issue Type: Improvement
>            Reporter: Markus Weimer
>            Assignee: Won Wook SONG
>            Priority: Minor
>              Labels: API, beginner
>             Fix For: 0.15
>
>
> {{EvaluatorRequestor}} and {{EvaluatorRequest.newBuilder()}} are almost always used together in a pattern that looks like this:
> {code}
> requestor.submit(EvaluatorRequest.newBuilder()
>   .setNumber(1)
>   .setMemory(64)
>   .setNumberOfCores(1)
>   .build());
> {code}
> It would be good to have a nicer, more fluid API here:
> {code}
> requestor.newRequest()
>   .setNumber(1)
>   .setMemory(64)
>   .setNumberOfCores(1)
>   .submit();
> {code}
> This could be done by creating a subclass of {{EvaluatorRequest.Builder}} which has a reference to the {{EvaluatorRequestor}} instance and implements {{.submit()}} as:
> {code}
> void submit(){
>   this.requestor.submit(this.build());
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)