You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by GitBox <gi...@apache.org> on 2021/07/25 15:26:55 UTC

[GitHub] [incubator-shenyu] hoobiee opened a new pull request #1810: Simplify some code

hoobiee opened a new pull request #1810:
URL: https://github.com/apache/incubator-shenyu/pull/1810


   I found some code to simplify when using IDEA to inspect the code, so I submit a PR here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter commented on pull request #1810: Simplify some code

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1810:
URL: https://github.com/apache/incubator-shenyu/pull/1810#issuecomment-886219328


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1810](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4102a32) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/5154e6f487c4d51dc8e022f2e2bf360841cabda4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5154e6f) will **decrease** coverage by `0.28%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1810      +/-   ##
   ============================================
   - Coverage     63.18%   62.89%   -0.29%     
   + Complexity     2466     2459       -7     
   ============================================
     Files           487      487              
     Lines         10633    10633              
     Branches       1066     1066              
   ============================================
   - Hits           6718     6688      -30     
   - Misses         3386     3423      +37     
   + Partials        529      522       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ext/path/handler/ContextPathPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNvbnRleHQtcGF0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9jb250ZXh0L3BhdGgvaGFuZGxlci9Db250ZXh0UGF0aFBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `10.00% <100.00%> (ø)` | |
   | [...ugin/hystrix/handler/HystrixPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9oYW5kbGVyL0h5c3RyaXhQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `54.54% <100.00%> (ø)` | |
   | [...ponse/handler/ModifyResponsePluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvaGFuZGxlci9Nb2RpZnlSZXNwb25zZVBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...elimiter/handler/RateLimiterPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJhdGVsaW1pdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3JhdGVsaW1pdGVyL2hhbmRsZXIvUmF0ZUxpbWl0ZXJQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `69.69% <100.00%> (-1.52%)` | :arrow_down: |
   | [...in/redirect/handler/RedirectPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlZGlyZWN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3JlZGlyZWN0L2hhbmRsZXIvUmVkaXJlY3RQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `10.00% <100.00%> (ø)` | |
   | [...u/plugin/request/handler/RequestPluginHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlcXVlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmVxdWVzdC9oYW5kbGVyL1JlcXVlc3RQbHVnaW5IYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ugin/resilience4j/handler/Resilience4JHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc2lsaWVuY2U0ai9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9yZXNpbGllbmNlNGovaGFuZGxlci9SZXNpbGllbmNlNEpIYW5kbGVyLmphdmE=) | `7.14% <100.00%> (ø)` | |
   | [...ugin/rewrite/handler/RewritePluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmV3cml0ZS9oYW5kbGVyL1Jld3JpdGVQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `10.00% <100.00%> (ø)` | |
   | [...henyu/plugin/waf/handler/WafPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXdhZi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi93YWYvaGFuZGxlci9XYWZQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `35.13% <0.00%> (-22.98%)` | :arrow_down: |
   | ... and [4 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5154e6f...4102a32](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1810: Simplify some code

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1810:
URL: https://github.com/apache/incubator-shenyu/pull/1810#issuecomment-886219328


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1810](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4102a32) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/5154e6f487c4d51dc8e022f2e2bf360841cabda4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5154e6f) will **decrease** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1810      +/-   ##
   ============================================
   - Coverage     63.18%   63.17%   -0.01%     
     Complexity     2466     2466              
   ============================================
     Files           487      487              
     Lines         10633    10633              
     Branches       1066     1066              
   ============================================
   - Hits           6718     6717       -1     
   - Misses         3386     3393       +7     
   + Partials        529      523       -6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ext/path/handler/ContextPathPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNvbnRleHQtcGF0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9jb250ZXh0L3BhdGgvaGFuZGxlci9Db250ZXh0UGF0aFBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `10.00% <100.00%> (ø)` | |
   | [...ugin/hystrix/handler/HystrixPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9oYW5kbGVyL0h5c3RyaXhQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `54.54% <100.00%> (ø)` | |
   | [...ponse/handler/ModifyResponsePluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvaGFuZGxlci9Nb2RpZnlSZXNwb25zZVBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...elimiter/handler/RateLimiterPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJhdGVsaW1pdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3JhdGVsaW1pdGVyL2hhbmRsZXIvUmF0ZUxpbWl0ZXJQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `71.21% <100.00%> (ø)` | |
   | [...in/redirect/handler/RedirectPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlZGlyZWN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3JlZGlyZWN0L2hhbmRsZXIvUmVkaXJlY3RQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `10.00% <100.00%> (ø)` | |
   | [...u/plugin/request/handler/RequestPluginHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlcXVlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmVxdWVzdC9oYW5kbGVyL1JlcXVlc3RQbHVnaW5IYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ugin/resilience4j/handler/Resilience4JHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc2lsaWVuY2U0ai9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9yZXNpbGllbmNlNGovaGFuZGxlci9SZXNpbGllbmNlNEpIYW5kbGVyLmphdmE=) | `7.14% <100.00%> (ø)` | |
   | [...ugin/rewrite/handler/RewritePluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmV3cml0ZS9oYW5kbGVyL1Jld3JpdGVQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `10.00% <100.00%> (ø)` | |
   | [...henyu/plugin/waf/handler/WafPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXdhZi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi93YWYvaGFuZGxlci9XYWZQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...henyu/plugin/grpc/resolver/ShenyuNameResolver.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWdycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vZ3JwYy9yZXNvbHZlci9TaGVueXVOYW1lUmVzb2x2ZXIuamF2YQ==) | `58.94% <0.00%> (-4.22%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5154e6f...4102a32](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] codecov-commenter edited a comment on pull request #1810: Simplify some code

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1810:
URL: https://github.com/apache/incubator-shenyu/pull/1810#issuecomment-886219328


   # [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1810](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4102a32) into [master](https://codecov.io/gh/apache/incubator-shenyu/commit/5154e6f487c4d51dc8e022f2e2bf360841cabda4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5154e6f) will **increase** coverage by `0.12%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/graphs/tree.svg?width=650&height=150&src=pr&token=k89XYIkOHK&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1810      +/-   ##
   ============================================
   + Coverage     63.18%   63.30%   +0.12%     
     Complexity     2466     2466              
   ============================================
     Files           487      487              
     Lines         10633    10633              
     Branches       1066     1066              
   ============================================
   + Hits           6718     6731      +13     
   + Misses         3386     3377       -9     
   + Partials        529      525       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ext/path/handler/ContextPathPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWNvbnRleHQtcGF0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9jb250ZXh0L3BhdGgvaGFuZGxlci9Db250ZXh0UGF0aFBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `10.00% <100.00%> (ø)` | |
   | [...ugin/hystrix/handler/HystrixPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh5c3RyaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHlzdHJpeC9oYW5kbGVyL0h5c3RyaXhQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `54.54% <100.00%> (ø)` | |
   | [...ponse/handler/ModifyResponsePluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vZGlmeS1yZXNwb25zZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9tb2RpZnkvcmVzcG9uc2UvaGFuZGxlci9Nb2RpZnlSZXNwb25zZVBsdWdpbkRhdGFIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...elimiter/handler/RateLimiterPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJhdGVsaW1pdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3JhdGVsaW1pdGVyL2hhbmRsZXIvUmF0ZUxpbWl0ZXJQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `71.21% <100.00%> (ø)` | |
   | [...in/redirect/handler/RedirectPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlZGlyZWN0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvcGx1Z2luL3JlZGlyZWN0L2hhbmRsZXIvUmVkaXJlY3RQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `10.00% <100.00%> (ø)` | |
   | [...u/plugin/request/handler/RequestPluginHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlcXVlc3Qvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmVxdWVzdC9oYW5kbGVyL1JlcXVlc3RQbHVnaW5IYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ugin/resilience4j/handler/Resilience4JHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJlc2lsaWVuY2U0ai9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi9yZXNpbGllbmNlNGovaGFuZGxlci9SZXNpbGllbmNlNEpIYW5kbGVyLmphdmE=) | `7.14% <100.00%> (ø)` | |
   | [...ugin/rewrite/handler/RewritePluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXJld3JpdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vcmV3cml0ZS9oYW5kbGVyL1Jld3JpdGVQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `10.00% <100.00%> (ø)` | |
   | [...henyu/plugin/waf/handler/WafPluginDataHandler.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXdhZi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3BsdWdpbi93YWYvaGFuZGxlci9XYWZQbHVnaW5EYXRhSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | |
   | [...enyu/client/tars/TarsServiceBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LXRhcnMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9jbGllbnQvdGFycy9UYXJzU2VydmljZUJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=) | `59.45% <0.00%> (+1.35%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/incubator-shenyu/pull/1810/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5154e6f...4102a32](https://codecov.io/gh/apache/incubator-shenyu/pull/1810?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] tydhot merged pull request #1810: Simplify some code

Posted by GitBox <gi...@apache.org>.
tydhot merged pull request #1810:
URL: https://github.com/apache/incubator-shenyu/pull/1810


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-shenyu] tydhot commented on pull request #1810: Simplify some code

Posted by GitBox <gi...@apache.org>.
tydhot commented on pull request #1810:
URL: https://github.com/apache/incubator-shenyu/pull/1810#issuecomment-886219122


   thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org