You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/03 22:42:39 UTC

[jira] [Commented] (STORM-1226) Port backtype.storm.util to java

    [ https://issues.apache.org/jira/browse/STORM-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15131206#comment-15131206 ] 

ASF GitHub Bot commented on STORM-1226:
---------------------------------------

GitHub user knusbaum opened a pull request:

    https://github.com/apache/storm/pull/1074

    STORM-1226: Port backtype.storm.util to java

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/knusbaum/incubator-storm util-conversion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1074.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1074
    
----
commit cc2daf3b41df371b85c505f3f25cf6de683e8eb8
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-13T20:05:24Z

    first batch of util.clj functions translated to java

commit 41d229be2c26b4dc28cb0242624e7194bec4bd9d
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-13T20:59:06Z

    upmerged with org.apache.storm reorg

commit 912d14c169a84f25f1814651167cb603ad544fc6
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-14T19:51:07Z

    fixing the failing test in supervisor-test due to find-first translation

commit 65522f09e9bbf116d4bd6b5b3d3018ddbf6f3141
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-14T20:17:47Z

    translation finished up to find-first, passing all tests

commit d4a7af67596557eccde232f8246617504f5460b6
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-20T16:37:06Z

    passing test, done up to uuid

commit b6edf16937a92f97b2263e07a17cbcf1975a8da8
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-20T22:11:59Z

    translate batch 3

commit 7de457eff0e514b9578c7c23ff89aff16d1e87b1
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-20T22:23:27Z

    passing tests. In the middle of replacing map-val

commit c0aff49cacd95de10ac31afa770d5d511595739e
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-20T23:07:27Z

    Merge branch 'STORM-1226' of https://github.com/rfarivar/storm into ystorm-2572-util-translate-batch-3

commit 4067809bfcf5921fc1a97915ac331e1a1c4a1d05
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-21T15:36:49Z

    fix failing tests

commit 56d48faac918123af46f1e021e38549fa6a4cf6c
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-21T20:44:44Z

    creates package to help with mocking static methods

commit f478858842ee075492e7392a72a3a1605c48b66e
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-21T20:46:28Z

    Batch 1 complete, all tests passing

commit 43da3c607b38f7b45a1f54b6be3149f994407c4e
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-21T21:32:21Z

    moves staticmocking under test/

commit b370d9e9b76fe146728403be69ea151baf933a46
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-01-21T21:57:18Z

    Merge remote-tracking branch 'reza/STORM-1226' into ystorm-2572-util-translate-batch-3

commit 77e10d4c151dbd9ec3b418686b5f04ddc06db9e4
Author: Reza Farivar <rf...@yahoo-inc.com>
Date:   2016-01-22T21:07:19Z

    Merge pull request #1 from d2r/ystorm-2572-util-translate-batch-3
    
    util translate batch 3

commit eff86b2493a09536d79dbda95bb2099dfa1abf67
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-25T17:05:44Z

    Translation up to the middle of batch 2, batch 1 and 3 complete

commit 69c3ab748684db5a35f8abf6ca61fe7cfc45894c
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-25T17:45:07Z

    upmerged to master

commit c9d62e9d028d0520886b6418dd263fe4150380bd
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-28T21:18:19Z

    batch 2 done

commit c7c0a105e68c688a65890ec3a4b28295c1238119
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-01-28T23:36:50Z

    upmerged, passing all unit tests

commit 058d73b7907cdbe8c652d5301dc206e264a02e69
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-01-29T17:31:25Z

    Lots of progress

commit 4169285bb9d906d6fc7964a5910a473a71ebf478
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-02-01T18:20:10Z

    Merge branch 'STORM-1226' of https://github.com/rfarivar/storm into util-conversion

commit 480af35f4bf8ac7666d270f203082176dd192731
Author: rfarivar <rf...@yahoo-inc.com>
Date:   2016-02-02T16:18:23Z

    all functions in batch 4 except uptime-computer (halfway translated) and redirect-stdio-to-slf4j

commit 7d486cb28c5f75b9b1cf49325eaec32e667259d6
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-02-02T16:43:46Z

    Batch 5 done.

commit b49a06581a87ef16df999c75d4de7067ab34e981
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-02-02T16:46:54Z

    Merge branch 'STORM-1226' of https://github.com/rfarivar/storm into util-conversion

commit 01b830056b09bd274a8e7fa7b2e7343d70483137
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-02-02T18:49:23Z

    fixing up some stuff.

commit acc77f897f7234a3b6930be6f914b2723b5e0d14
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-02-02T19:23:04Z

    Addressed comments from pull #1043

commit 30635f8b0fefdf7ba5e6e0709d1e2eaaed09c3f7
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-02-02T19:35:09Z

    Addressed comments from pull #1043

commit 5d156bdd27b9c278f02ee0f81f2ba19b6af5751a
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-02-02T22:49:39Z

    translate keywork functions in util

commit fc5050fd439b604abb7e749dd9b7b01ff5cedc63
Author: Kyle Nusbaum <ky...@gmail.com>
Date:   2016-02-03T00:15:13Z

    Fixing up some things.

commit d2679a800849311e783812b7d3419cbcdeb8adb4
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-02-03T18:35:57Z

    Merge remote-tracking branch 'kyle-apache/util-conversion' into storm-1226-keyword-fns

commit 02bf1100ca8e1248870d2947cccd33a15dc861d8
Author: Derek Dagit <de...@yahoo-inc.com>
Date:   2016-02-03T18:36:20Z

    minor clean-up

----


> Port backtype.storm.util to java
> --------------------------------
>
>                 Key: STORM-1226
>                 URL: https://issues.apache.org/jira/browse/STORM-1226
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Reza Farivar
>              Labels: java-migration, jstorm-merger
>
> Port backtype.storm.util from clojure to java.  In as many instances as possible the same interface should be maintained, and calls to clojure functions in the rest of the code should be replaces with calls to the corresponding java code.
> Some similar functions can be found at  
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/utils/JStormUtils.java
> Although they are not identical.
> For function callbacks we may need to evaluate adding in appropriate callback interfaces instead.  Please try to avoid using clojure internal java classes unless necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)