You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/23 13:33:49 UTC
[GitHub] [flink] Myasuka opened a new pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Myasuka opened a new pull request #14175:
URL: https://github.com/apache/flink/pull/14175
## What is the purpose of the change
Correct documentation about savepoint self-contained
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] klion26 commented on pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
klion26 commented on pull request #14175:
URL: https://github.com/apache/flink/pull/14175#issuecomment-735047044
@Myasuka thanks for your contribution, maybe this is duplicated with FLINK-19381/[PR](https://github.com/apache/flink/pull/13488) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 commented on pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
carp84 commented on pull request #14175:
URL: https://github.com/apache/flink/pull/14175#issuecomment-735533931
@klion26 I think you're right, this PR duplicates #13488 . Please check out Stephan's comments and address them in #13488 as well, thanks.
@Myasuka @StephanEwen I'm closing this PR and let's further track it in #13488 , thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14175:
URL: https://github.com/apache/flink/pull/14175#issuecomment-732177210
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aa47d7fba86d5a0662b7fd6f390645ae87771f9c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "aa47d7fba86d5a0662b7fd6f390645ae87771f9c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa47d7fba86d5a0662b7fd6f390645ae87771f9c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14175:
URL: https://github.com/apache/flink/pull/14175#issuecomment-732177210
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aa47d7fba86d5a0662b7fd6f390645ae87771f9c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9958",
"triggerID" : "aa47d7fba86d5a0662b7fd6f390645ae87771f9c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa47d7fba86d5a0662b7fd6f390645ae87771f9c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14175:
URL: https://github.com/apache/flink/pull/14175#issuecomment-732166652
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit aa47d7fba86d5a0662b7fd6f390645ae87771f9c (Mon Nov 23 13:37:18 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] carp84 closed pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
carp84 closed pull request #14175:
URL: https://github.com/apache/flink/pull/14175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on a change in pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on a change in pull request #14175:
URL: https://github.com/apache/flink/pull/14175#discussion_r532205583
##########
File path: docs/ops/state/savepoints.md
##########
@@ -110,13 +110,8 @@ For example with a `FsStateBackend` or `RocksDBStateBackend`:
/savepoints/savepoint-:shortjobid-:savepointid/...
{% endhighlight %}
-<div class="alert alert-info">
- <strong>Note:</strong>
-Although it looks as if the savepoints may be moved, it is currently not possible due to absolute paths in the <code>_metadata</code> file.
-Please follow <a href="https://issues.apache.org/jira/browse/FLINK-5778">FLINK-5778</a> for progress on lifting this restriction.
-</div>
-
-Note that if you use the `MemoryStateBackend`, metadata *and* savepoint state will be stored in the `_metadata` file. Since it is self-contained, you may move the file and restore from any location.
+Note that if you use the `MemoryStateBackend`, metadata *and* savepoint state will be stored in the `_metadata` file.
Review comment:
What do you think about changing this to:
```
Savepoints can generally be moved by moving (or copying) the entire savepoint directory to a different location, and Flink will be able to restore from the moved savepoint.
<div class="alert alert-warning">An exception to that is if *entropy injection* is activated: In that case the savepoint directory will not contain all savepoint data files, because the injected path entropy spreads the files over many directories. Lacking a common savepoint root directory, the savepoints will contain absolute path references, which prevent moving the directory.</div>
<div class="alert alert-warning">Unlike savepoints, checkpoints cannot generally be moved to a different location, because checkpoints may include some absolute path references.</div>
If you use the `MemoryStateBackend`, metadata *and* savepoint state will be stored in the `_metadata` file, so don't be confused by the absence of additional data files.
```
I would drop the reference to a closed JIRA issue here, users should not feel like they need to look into the bug tracker to understand a feature.
##########
File path: docs/ops/state/savepoints.md
##########
@@ -94,7 +94,7 @@ When triggering a savepoint, a new savepoint directory is created where the data
<strong>Attention:</strong> The target directory has to be a location accessible by both the JobManager(s) and TaskManager(s) e.g. a location on a distributed file-system.
Review comment:
Can we change this to "...location on a distributed file-system or Object Store." ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14175:
URL: https://github.com/apache/flink/pull/14175#issuecomment-732177210
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "aa47d7fba86d5a0662b7fd6f390645ae87771f9c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9958",
"triggerID" : "aa47d7fba86d5a0662b7fd6f390645ae87771f9c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* aa47d7fba86d5a0662b7fd6f390645ae87771f9c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9958)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #14175: [FLINK-20288][docs] Correct documentation about savepoint self-contained
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #14175:
URL: https://github.com/apache/flink/pull/14175#issuecomment-734743889
@klion26 , could you please take a view on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org