You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/06/05 03:29:08 UTC
[GitHub] [incubator-tvm] leonwanghui opened a new pull request #5733: Make Tensor struct public in Rust runtime
leonwanghui opened a new pull request #5733:
URL: https://github.com/apache/incubator-tvm/pull/5733
Signed-off-by: leonwanghui <wa...@gmail.com>
Hi all, this PR is proposed to make some private member inside `Tensor` struct public so that it could be embedded into other crates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leonwanghui commented on pull request #5733: Make Tensor struct public in Rust runtime
Posted by GitBox <gi...@apache.org>.
leonwanghui commented on pull request #5733:
URL: https://github.com/apache/incubator-tvm/pull/5733#issuecomment-642384629
Already fixed by transferring `Tensor` to `DLTensor` ABI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] tqchen commented on pull request #5733: Make Tensor struct public in Rust runtime
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5733:
URL: https://github.com/apache/incubator-tvm/pull/5733#issuecomment-639559062
I think it is useful to have some struct available to other usecases. However, as per layered design of TVM runtime, the current Tensor structure is not really C ABI compatible, so has some cross language concerns. The best way to use the struct is to use it through a generic DLTensor ABI, which is available as part of TVM. I believe @jroesch would also do follow up PR aroun dthat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leonwanghui commented on pull request #5733: Make Tensor struct public in Rust runtime
Posted by GitBox <gi...@apache.org>.
leonwanghui commented on pull request #5733:
URL: https://github.com/apache/incubator-tvm/pull/5733#issuecomment-640316070
@tqchen Thanks for the replies, I really agree with you on using the generic DLTensor struct and the design of its ABI is totally suitable in my case, but currently for me it's necessary to leverage the rich wrapper features of `Tensor` (such like free transition with `ndarray` crates), would be appreciated if @jroesch could offer some kind suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] leonwanghui closed pull request #5733: Make Tensor struct public in Rust runtime
Posted by GitBox <gi...@apache.org>.
leonwanghui closed pull request #5733:
URL: https://github.com/apache/incubator-tvm/pull/5733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org