[jira] [Commented] (HBASE-17768) Makefile should recompile only the changed sources

["Enis Soztutar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905727#comment-15905727 ] 

Enis Soztutar commented on HBASE-17768:
---------------------------------------

Thanks Sudeep for the patch. 
It does not apply to the latest branch code. Maybe you need to rebase. 
Do we need the script to invoke protoc. Previously we used to do that from make itself. Does it always recompile with protoc before? 

My compilation failed with: 
{code}
In file included from ./test-util/test-util.h:28:0,
                 from test-util/test-util.cc:20:
./test-util/mini-cluster.h:22:17: fatal error: jni.h: No such file or directory
compilation terminated.
make: *** [build/debug/test-util/test-util.o] Error 1
{code} 
This is in a non-docker centos-7. Let me check whether it is the lack of JAVA_HOME env var. 

> Makefile should recompile only the changed sources
> --------------------------------------------------
>
>                 Key: HBASE-17768
>                 URL: https://issues.apache.org/jira/browse/HBASE-17768
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sudeep Sunthankar
>            Assignee: Sudeep Sunthankar
>         Attachments: HBASE-17768.HBASE-14850.v1.patch
>
>
> Current Makefile builds everything including PB sources  everytime. This patch addresses the issue



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)