[GitHub] [incubator-doris] morningman commented on a change in pull request #1443: Persist auth info in LoadJob

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #1443: Persist auth info in LoadJob
URL: https://github.com/apache/incubator-doris/pull/1443#discussion_r301055939
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java
 ##########
 @@ -185,6 +185,21 @@ public long getTransactionId() {
         return transactionId;
     }
 
+    /**
+     * Show table names for frontend
+     * If table name could not be found by id, the table id will be used instead.
+     *
+     * @return
+     */
+    abstract Set<String> getTableNamesForShow();
+
+    /**
+     * Return the real table names by table ids.
+     * Throw MetaNofFoundException when table name could not be found.
+     * @return
+     */
 
 Review comment:
   Could add more comment to describe the difference between getTableNamesForShow() and getTableNames().
   For example, getTableNames() is used only for checking privilege?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org