You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/22 03:27:01 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #23326: Remove `pip` check in setup.py to allow installation via other package managers (e.g. `poetry`)

Abacn commented on code in PR #23326:
URL: https://github.com/apache/beam/pull/23326#discussion_r977157154


##########
sdks/python/setup.py:
##########
@@ -95,16 +95,6 @@ def get_version():
 different technologies and user communities.
 '''
 
-REQUIRED_PIP_VERSION = '7.0.0'

Review Comment:
   The context was here: https://github.com/apache/beam/issues/22218#issuecomment-1196014115. We may change REQUIRED_PIP_VERSION -> RECOMMENDED_MIN_PIP_VERSION and change the warning accordingly. And put the code in a try clause and catch `DistributionNotFound`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org