You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by vladimirtkach <gi...@git.apache.org> on 2018/03/01 14:59:06 UTC

[GitHub] drill pull request #1143: DRILL-1491: Support for JDK 8

GitHub user vladimirtkach opened a pull request:

    https://github.com/apache/drill/pull/1143

    DRILL-1491: Support for JDK 8

    Changed jdk version from 7 to 8 in pom.xml, drill-config.sh and others

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vladimirtkach/drill DRILL-1491

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1143.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1143
    
----
commit 0aeeacc9e528b6dea80385bbf53e7259a6813b08
Author: Vladimir Tkach <vo...@...>
Date:   2018-02-28T13:32:55Z

    DRILL-1491: Support for JDK 8
    
    Changed jdk version from 7 to 8 in pom.xml travis and drill-config.sh

----


---

[GitHub] drill pull request #1143: DRILL-1491: Support for JDK 8

Posted by vladimirtkach <gi...@git.apache.org>.

Github user vladimirtkach commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1143#discussion_r172141644
  
    --- Diff: .travis.yml ---
    @@ -17,9 +17,9 @@ before_install: git fetch --unshallow
     sudo: required
     language: java
     jdk:
    -  - openjdk7
    +  - openjdk8
     cache:
       directories:
       - "$HOME/.m2"
     install: MAVEN_OPTS="-Xms1G -Xmx1G" mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true
    -script: mvn install -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest" -DforkCount=1 -DmemoryMb=2560 -DdirectMemoryMb=4608
    +script: mvn install -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest" -DforkCount=1 -DmemoryMb=2560 -DdirectMemoryMb=6008
    --- End diff --
    
    @ilooner yes , there was:
    testFlattenUpperLimit(org.apache.drill.exec.physical.unit.TestOutputBatchSize)  Time elapsed: 260.527 sec  <<< ERROR!
    java.lang.OutOfMemoryError: GC overhead limit exceeded
    
    For now changed to previous value.


---

[GitHub] drill pull request #1143: DRILL-1491: Support for JDK 8

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1143#discussion_r171997640
  
    --- Diff: .travis.yml ---
    @@ -17,9 +17,9 @@ before_install: git fetch --unshallow
     sudo: required
     language: java
     jdk:
    -  - openjdk7
    +  - openjdk8
     cache:
       directories:
       - "$HOME/.m2"
     install: MAVEN_OPTS="-Xms1G -Xmx1G" mvn install --batch-mode -DskipTests=true -Dmaven.javadoc.skip=true -Dmaven.source.skip=true
    -script: mvn install -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest" -DforkCount=1 -DmemoryMb=2560 -DdirectMemoryMb=4608
    +script: mvn install -DexcludedGroups="org.apache.drill.categories.SlowTest,org.apache.drill.categories.UnlikelyTest,org.apache.drill.categories.SecurityTest" -DforkCount=1 -DmemoryMb=2560 -DdirectMemoryMb=6008
    --- End diff --
    
    @vladimirtkach Why the change in direct memory for travis? Did you run into an issue with the previous setting?


---

[GitHub] drill pull request #1143: DRILL-1491: Support for JDK 8

Posted by parthchandra <gi...@git.apache.org>.

Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1143#discussion_r173093078
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java ---
    @@ -650,6 +650,7 @@ public void dataArrived(final QueryDataBatch result, final ConnectionThrottle th
     
       @Test // DRILL-2383: Cancellation TC 3: cancel after all result set are produced but not all are fetched
       @Repeat(count = NUM_RUNS)
    +  @Ignore
    --- End diff --
    
    Please log a JIRA and reference it in this ignore statement


---

[GitHub] drill issue #1143: DRILL-1491: Support for JDK 8

Posted by parthchandra <gi...@git.apache.org>.

Github user parthchandra commented on the issue:

    https://github.com/apache/drill/pull/1143
  
    +1


---

[GitHub] drill pull request #1143: DRILL-1491: Support for JDK 8

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/1143


---

[GitHub] drill pull request #1143: DRILL-1491: Support for JDK 8

Posted by vladimirtkach <gi...@git.apache.org>.

Github user vladimirtkach commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1143#discussion_r173480628
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/server/TestDrillbitResilience.java ---
    @@ -650,6 +650,7 @@ public void dataArrived(final QueryDataBatch result, final ConnectionThrottle th
     
       @Test // DRILL-2383: Cancellation TC 3: cancel after all result set are produced but not all are fetched
       @Repeat(count = NUM_RUNS)
    +  @Ignore
    --- End diff --
    
    @parthchandra added jira to ignore annotation https://issues.apache.org/jira/browse/DRILL-6228


---

[GitHub] drill issue #1143: DRILL-1491: Support for JDK 8

Posted by ilooner <gi...@git.apache.org>.

Github user ilooner commented on the issue:

    https://github.com/apache/drill/pull/1143
  
    @vladimirtkach This test is failing on Travis:
    
    ```
      TestOutputBatchSize.testFlattenUpperLimit:695->getExpectedSize:58->PhysicalOpUnitTestBase.getReaderListForJsonBatches:483->PhysicalOpUnitTestBase.getRecordReadersForJsonBatches:479->PhysicalOpUnitTestBase.getJsonReadersFromBatchString:505 Â» TestTimedOut
    ```


---